fix: prevent indentation shift for tree items without parent icons#308165
Open
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: prevent indentation shift for tree items without parent icons#308165maruthang wants to merge 1 commit intomicrosoft:mainfrom
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When a collapsible parent item lacks an icon, alignIconWithTwisty() incorrectly triggered alignment for leaf children. This caused leaf items to shift left (twistie space hidden) while collapsible siblings kept their twistie space, resulting in inconsistent indentation at the same depth level. Return false from alignIconWithTwisty when the parent lacks an icon, so the alignment only applies when the parent has an icon and can establish a consistent visual hierarchy. Fixes microsoft#307350
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307350
Summary
alignIconWithTwisty()incorrectly triggered alignment for leaf children, hiding their twistie space (width: 0) while collapsible siblings kept theirs. This caused inconsistent indentation at the same depth level.alignIconWithTwisty()to returnfalse, so alignment only applies when the parent has an icon and can establish a consistent visual hierarchy.Test plan