Repository navigation
fix: avoid blocking libuv threadpool workers in PolicyWatcher - #84
Merged
Merged
Conversation
Replace Napi::AsyncProgressQueueWorker with Napi::TypedThreadSafeFunction so watchers do not permanently occupy libuv worker threads for the lifetime of the process. On macOS, refresh policies directly on the FSEventStream serial dispatch queue without a worker thread; on Windows, run the WaitForMultipleObjects loop on a dedicated std::thread.
Robo (deepak1556)
enabled auto-merge (squash)
October 28, 2026 14:35
Alex Ross (alexr00)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode#343189
Replace
Napi::AsyncProgressQueueWorkerwithNapi::TypedThreadSafeFunctionso watchers do not permanently occupy libuv worker threads for the lifetime of the process. On macOS, refresh policies directly on the FSEventStream serial dispatch queue without a worker thread; on Windows, run the WaitForMultipleObjects loop on a dedicated std::thread.