[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios#10896
Merged
Merged
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test case for Python SDK Spector mock API
[python] Add mock_api coverage for single-discriminator no-subtypes scenario
Jun 4, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
…-python-sdk-spector # Conflicts: # packages/http-client-python/package-lock.json Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Contributor
Author
msyyc
reviewed
Jun 9, 2026
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[python] Add mock_api coverage for single-discriminator no-subtypes scenario
[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios
Jun 9, 2026
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
msyyc
approved these changes
Jun 10, 2026
ChenxiJiang333
approved these changes
Jun 10, 2026
JennyPng
pushed a commit
to JennyPng/typespec
that referenced
this pull request
Jun 10, 2026
…nd body-root nested scenarios (microsoft#10896) This adds python mock API coverage for new Spector scenarios introduced by the cross-language spec updates (PR microsoft#10841): a discriminated model with no declared subtypes, and a `@bodyRoot` parameter nested inside a wrapper model. The PR extends existing single-discriminator tests in both sync and async suites, adds new shared body-root tests, and aligns local spec inputs to a version that contains the scenarios. - **Test coverage: single-discriminator no-subtypes (shared sync/async)** - Extended existing shared tests to cover: - `get_no_subtypes_model()` - `put_no_subtypes_model(...)` - Added `Fish` model assertions to validate the expected wire payload shape (`kind`, `size`). - **Test coverage: body-root nested (shared sync/async)** - Added new shared tests (`test_parameters_body_root.py` and `asynctests/test_parameters_body_root_async.py`) covering the `nested(...)` operation with a `BodyRootModel` (`category`, `link_type`, `was_successful`). - Validated locally against the Spector mock server. - **Spec dependency update for scenario availability** - Updated `@typespec/http-specs` in `packages/http-client-python/package.json` (and lockfile) to a version containing the new scenario definitions used by regeneration. - **Change tracking** - Added a Chronus `internal` entry for `@typespec/http-client-python`. ```python def test_get_no_subtypes_model(client): assert client.get_no_subtypes_model() == Fish(kind="salmon", size=10) def test_put_no_subtypes_model(client): client.put_no_subtypes_model(Fish(kind="salmon", size=10)) def test_nested(client): client.nested(BodyRootModel(category="widget", link_type="hard", was_successful=True)) ``` > Note: The third scenario from PR microsoft#10841, `Parameters_Query_SpecialChar_dollarSign`, is intentionally **not** covered. There is an upstream spec inconsistency where `main.tsp` declares `@route("/dollarSign")` (camelCase) while `mockapi.ts` registers the endpoint at `/dollar-sign` (kebab-case). The mock server only serves `/dollar-sign`, while the generated SDK correctly calls `/dollarSign`, so the test would 404. This requires a fix in `@typespec/http-specs` before SDK coverage can pass. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds python mock API coverage for new Spector scenarios introduced by the cross-language spec updates (PR #10841): a discriminated model with no declared subtypes, and a
@bodyRootparameter nested inside a wrapper model. The PR extends existing single-discriminator tests in both sync and async suites, adds new shared body-root tests, and aligns local spec inputs to a version that contains the scenarios.Test coverage: single-discriminator no-subtypes (shared sync/async)
get_no_subtypes_model()put_no_subtypes_model(...)Fishmodel assertions to validate the expected wire payload shape (kind,size).Test coverage: body-root nested (shared sync/async)
test_parameters_body_root.pyandasynctests/test_parameters_body_root_async.py) covering thenested(...)operation with aBodyRootModel(category,link_type,was_successful).Spec dependency update for scenario availability
@typespec/http-specsinpackages/http-client-python/package.json(and lockfile) to a version containing the new scenario definitions used by regeneration.Change tracking
internalentry for@typespec/http-client-python.