[ResourceLock] Replace class-level DoNotParallelize with ResourceLock in TrxLongPathHelperTests

[Amaury Levé (Evangelink)]

Summary

• In the method-level-parallelized Microsoft.Testing.Extensions.UnitTests project, replace the class-level [DoNotParallelize] on TrxLongPathHelperTests with [ResourceLock(WellKnownResources.CurrentDirectory)].
• Both test methods mutate the process-wide current directory and restore the original value in finally; the class-level lock is reacquired for each method and serializes those conflicting mutations without suppressing unrelated parallel tests.
• Clarify the class remarks to document why the narrower lock is sufficient.

Validation

• bash ./build.sh — succeeded with 0 errors and 0 warnings.
• The test class is guarded by #if !NETCOREAPP and therefore only builds for net462/net472, which could not run on the Linux workflow runner. A net8.0 --filter-uid probe confirmed that no matching tests are compiled for that target framework.

Recovered from the safe-output failure in https://github.com/microsoft/testfx/actions/runs/32812234406.

[Copilot]

Pull request overview

Replaces broad test parallelization suppression with a current-directory resource lock.

Changes:

• Applies WellKnownResources.CurrentDirectory.
• Documents lock scope and directory restoration.

Show a summary per file

File	Description
TrxLongPathHelperTests.cs	Narrows current-directory synchronization.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Balanced

[Amaury Levé (Evangelink)]

Good catch — fixed in 5d2cef9. StackTraceSourceLocationResolverTests now takes a read lock on WellKnownResources.CurrentDirectory, so its readers coordinate with the writer lock in TrxLongPathHelperTests. The focused net462 run passed all 9 affected tests.

[github-actions]

🧪 Expert test review — PR #10718

No new or modified test methods were identified in the changed regions of this PR. The only diff hunk touches the class-level XML <remarks> documentation and swaps [DoNotParallelize] for [ResourceLock(WellKnownResources.CurrentDirectory)] on TrxLongPathHelperTests; neither test method's signature, attributes, or body fall within the changed lines. Nothing to review.

_{Re-run with /review-tests.}

🤖 Automated content by GitHub Copilot. Generated by the Test Reviewer on PR (on open / sync) workflow. · auto · 61.6 AIC · ⌖ 0.922 AIC · ⊞ 16.9K · [◷]( · ◷)

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

Scope note: The diff shows 119 changed files / ~3700 additions, but the PR's own unique changes (commits 64d4964 and 5d2cef9) touch only 2 test files. The rest is from merging main into the branch. This review covers the PR-specific changes:

1. TrxLongPathHelperTests.cs — Replaces [DoNotParallelize] with [ResourceLock(WellKnownResources.CurrentDirectory)] (write mode, the default). Remarks updated to explain the narrower serialization. Correct: both test methods mutate and restore the current directory in finally blocks, so a per-method resource lock serializes the mutations without suppressing unrelated parallel tests.

2. StackTraceSourceLocationResolverTests.cs — Adds [ResourceLock(WellKnownResources.CurrentDirectory, Mode = ResourceAccessMode.Read)]. Correct: this class reads the current directory (via relative path resolution) and would be affected by concurrent mutations from TrxLongPathHelperTests. The read lock serializes against writers while still allowing other readers to run in parallel.

Both changes are well-motivated, correctly scoped, and the #if !NETCOREAPP guard on the TRX tests means there is no cross-TFM risk on .NET Core/5+. The class is only compiled for net462/net472.

[Copilot]

Review details

• Files reviewed: 119/119 changed files
• Comments generated: 1
• Review effort level: Balanced