Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
the two drift apart. -->
<AspireHostingTestingVersion>13.4.6</AspireHostingTestingVersion>
<MicrosoftBuildVersion>17.11.48</MicrosoftBuildVersion>
<MicrosoftCodeAnalysisVersion>3.11.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisVersion>5.9.0</MicrosoftCodeAnalysisVersion>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 NU1605MicrosoftCodeAnalysisVersion is being bumped to 5.9.0 here, but the separately-pinned Microsoft.CodeAnalysis.Analyzers PackageVersion (elsewhere in this file, currently 5.6.0) is now lower than the >= 5.9.0-1.26328.17 required transitively by Microsoft.CodeAnalysis.Common/Microsoft.CodeAnalysis.CSharp.Workspaces 5.9.0. This causes an NU1605 downgrade error (promoted to a hard error) on every build leg. Raise the Microsoft.CodeAnalysis.Analyzers PackageVersion to 5.9.0 as well.

Suggested change
<MicrosoftCodeAnalysisVersion>5.9.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisVersion>5.9.0</MicrosoftCodeAnalysisVersion>

<MicrosoftCodeAnalysisVersionForTests>4.10.0</MicrosoftCodeAnalysisVersionForTests>
<MicrosoftCodeAnalysisVersionForSourceGen>4.8.0</MicrosoftCodeAnalysisVersionForSourceGen>
Comment on lines 32 to 33
<!-- Microsoft.CodeAnalysis.PublicApiAnalyzers / .BannedApiAnalyzers.
Expand Down
Loading