'dotnet test' fails in MTP if file 'Directory.Build.props' sets MSBuild property 'OutputPath' using MSBuild property 'Configuration'

[carl-quintero]

Describe the bug

When a MTP test project in .NET 10.0.100 (using either Microsoft.NET.Sdk or MSTest.Sdk) uses a file Directory.Build.props that changes the MSBuild property OutputPath to a value that uses the MSBuild property Configuration, dotnet test fails (although with different errors depending on the project sdk):

File Directory.Build.props:

<Project>
   <PropertyGroup>
      <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)obj\$(Configuration)\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
      <OutputPath>$(MSBuildThisFileDirectory)bin\$(Configuration)\$(MSBuildProjectName)\</OutputPath>
   </PropertyGroup>
</Project>

(Notice the use of the property $(Configuration))

Steps To Reproduce

Repos:

• Case 1 (Microsoft.NET.Sdk): https://github.com/carl-quintero/Sample-Microsoft.NET.Sdk

• Case 2 (MSTest.SDK): https://github.com/carl-quintero/Sample-MSTest.SDK

Steps:

1. Clone the repo(s)

2. Open a CMD terminal

3. Change the directory to the directory of the cloned repo

4. Run:

   dotnet test

Expected behavior

Tests should be found and executed

Actual behavior

• Case 1 (Microsoft.NET.Sdk):

  You get error:

  Get projects properties with MSBuild didn't execute properly with exit code: 1.

  (In this case at the very least it should be desirable a more helpful error message)

• Case 2 (MSTest.SDK):

  You get error:

  System.ComponentModel.Win32Exception (2): An error occurred trying to start process '<folder_redacted>\Sample-MSTest.SDK\bin\Test\net10.0\Test.exe' with working directory '<folder_redacted>\Sample-MSTest.SDK'. The system cannot find the file specified.
  

  Notice that the problem is that the output folder bin\Test\net10.0 is used instead of the correct one with the Configuration: bin\Debug\Test\net10.0

Additional context

dotnet test works fine if you delete (or rename) the file Directory.Build.props.

I am aware that I could use dotnet test --test-modules with the compiled binaries (which is what I use in CI/CD pipelines), but for development in the command-line I would like to keep using the dotnet test experience.

[nohwnd]

works correctly when setting global property: dotnet test /p:Configuration=Debug

So I am assuming the code reading the properties does not read the property from additional projects (Directory.build.props) properly (probably).

[carl-quintero]

Interesting.

It has something to do with the default value of $(Configuration), which for MSBuild is "Debug", but it is not taken into account by MTP when executing dotnet test and the property is evaluated as empty.

So, with your approach, I can use this workaround that makes dotnet test to work and doesn't force me to declare the Configuration value in each .csproj file of my solution:

<Project>
   <PropertyGroup>
      <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>   

      <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)obj\$(Configuration)\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
      <OutputPath>$(MSBuildThisFileDirectory)bin\$(Configuration)\$(MSBuildProjectName)\</OutputPath>
   </PropertyGroup>
</Project>

Still, a better error message for case 1 is required (GitHub Copilot was clueless) and a fix would be nice.

[nohwnd]

For reference error is coming from here: https://github.com/dotnet/sdk/blob/main/src/Cli/dotnet/Commands/Test/MTP/MSBuildHandler.cs#L26-L32

[Youssef1313]

This is related to parsing solution files, which we fixed already and will be available in the next patch of 10.0.1xx of .NET SDK. Fix is dotnet/sdk#51794

[Youssef1313]

Note that what you have is already not very ideal.

If you do dotnet build on solution, you should find that Configuration is being used. But then if you follow with dotnet build on project, Configuration is unlikely to be considered. (and this is all dotnet build, no dotnet test involved)

[Youssef1313]

Also better error message is tracked in dotnet/sdk#51802