CI: Tweak comments around feature enablement#3502
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI-related comments describing feature enablement behavior for clippy and nextest without changing execution logic.
Changes:
- Clarifies why Windows nextest does not use all features and why the
cifeature is added. - Clarifies why Windows/Mac clippy avoids all features and why the
cifeature is intentionally not used there.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
flowey/flowey_lib_hvlite/src/build_nextest_unit_tests.rs |
Updates comments around Windows feature selection for nextest unit test builds. |
flowey/flowey_lib_hvlite/src/_jobs/check_clippy.rs |
Updates comments around Windows/Mac feature selection for clippy checks. |
smalis-msft
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the comments around feature enablement for our clippy and nextest steps. No functional changes.