FIX: enforce POSIX native binary hardening - #810
Draft
Sumit Sarabhai (sumitmsft) wants to merge 1 commit into
Draft
Sumit Sarabhai (sumitmsft) wants to merge 1 commit into
Sumit Sarabhai (sumitmsft) wants to merge 1 commit into
Conversation
AB#48377 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Sumit Sarabhai (sumitmsft)
September 23, 2026 18:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
ELF linker flags must be restricted to Linux targets to avoid unsupported options on other UNIX platforms.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR strengthens POSIX native-extension binary hardening and adds regression coverage.
Changes:
- Defaults single-config builds to Release.
- Adds compiler and linker hardening flags.
- Adds source-contract and ELF validation tests.
| File | Summary |
|---|---|
tests/test_040_native_binary_hardening.py |
Verifies hardening configuration and Linux ELF properties. |
mssql_python/pybind/CMakeLists.txt |
Configures build defaults and native hardening flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+426
to
+430
| target_link_options(ddbc_bindings PRIVATE | ||
| -Wl,-z,relro | ||
| -Wl,-z,now | ||
| -Wl,-z,noexecstack | ||
| ) |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.1%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 78.4%
mssql_python.pybind.connection.connection_pool.cpp: 82.3%
mssql_python.pybind.connection.connection.cpp: 82.5%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%🔗 Quick Links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_FORTIFY_SOURCE=3when supported, otherwise level 2, excluding Debug buildsThe hardening options are private to
ddbc_bindings; simdutf compilation is unchanged. macOS retains its existing dynamic-link behavior, and Windows behavior is unchanged.Validation
AB#48377