feat(skill): introduce owasp-cicd#1246
feat(skill): introduce owasp-cicd#1246JasonTheDeveloper wants to merge 18 commits intomicrosoft:mainfrom
owasp-cicd#1246Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 87.63% 87.62% -0.02%
==========================================
Files 61 61
Lines 9328 9328
==========================================
- Hits 8175 8174 -1
- Misses 1153 1154 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@JasonTheDeveloper - will you run this one over HVE Core itself and share the report in this thread? |
|
@WilliamBerryiii yeah sure. I ran the OWASP Security Assessment ReportDate: 2026-04-01 Caution This prompt is an assistive tool only and does not replace professional security tooling (SAST, DAST, SCA, penetration testing, compliance scanners) or qualified human review. All AI-generated vulnerability findings must be reviewed and validated by qualified security professionals before use. AI outputs may contain inaccuracies, miss critical threats, or produce recommendations that are incomplete or inappropriate for your environment. Executive SummaryA comprehensive CI/CD security assessment was performed against the hve-core repository using the OWASP CI/CD Top 10 framework. All 10 controls were evaluated, producing 9 PASS findings and 1 NOT_ASSESSED finding (IAM configuration, which resides outside source code). No vulnerabilities were identified — the repository demonstrates strong pipeline security posture with SHA-pinned actions, least-privilege permissions, secret scanning, SBOM generation, build provenance attestation, and deterministic dependency management. All 10 findings passed through verification unchanged. Summary Counts
Severity Breakdown (FAIL + PARTIAL only)
Verification Summary
Findings by Frameworkowasp-cicd
Detailed Remediation GuidanceNone identified. Disproved FindingsNone. Remediation Checklist
No CONFIRMED or DOWNGRADED findings require remediation. Appendix: Skills Used
|
f96f754 to
ec8d96e
Compare
This makes me really happy! |
WilliamBerryiii
left a comment
There was a problem hiding this comment.
Thanks for this contribution — the content quality across all 10 reference documents is excellent and the agent integrations are thorough.
A few items to address before merge, detailed in inline comments below.
Positive observations:
- All 10 vulnerability reference documents follow a consistent, well-structured format
- Agent integrations (security-reviewer, codebase-profiler, finding-deep-verifier, skill-assessor) are all correctly updated
- Collection and plugin registrations are complete with correct
maturity: experimental - Symlinks follow the established conventions
- Using "index" rather than "master index" is the preferred wording — we will update the existing skills to match
- Using a hyphen in
security.collection.mdis the preferred punctuation — we will update existing entries to match
| 10. [09 Improper Artifact Integrity Validation](references/09-improper-artifact-integrity-validation.md) | ||
| 11. [10 Insufficient Logging and Visibility](references/10-insufficient-logging-visibility.md) | ||
|
|
||
| ## Skill layout |
There was a problem hiding this comment.
Missing Third-Party Attribution section
All three existing OWASP skills include a ## Third-Party Attribution section at the end of SKILL.md with:
- OWASP Foundation copyright notice
- CC BY-SA 4.0 license reference and link
- Source URL
- Modifications description
- OWASP® trademark disclaimer
Since this content is derived from OWASP's CC BY-SA 4.0 licensed material, this section is required for license compliance.
See owasp-agentic/SKILL.md lines 44-55 for the template to follow.
| content_based_on: "https://owasp.org/www-project-top-10-ci-cd-security-risks/" | ||
| --- | ||
|
|
||
| # OWASP CI/CD Top 10 — Skill Entry |
There was a problem hiding this comment.
Missing OWASP® trademark symbol
The existing skills use the registered trademark symbol in the heading:
# OWASP® Top 10 — Skill Entry# OWASP® LLM Top 10 — Skill Entry# OWASP® Agentic Top 10 — Skill Entry
| # OWASP CI/CD Top 10 — Skill Entry | |
| # OWASP® CI/CD Top 10 — Skill Entry |
|
|
||
| ### Scenario B — Unpatched build server compromise | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: extra blank line after the ### Scenario B heading. All other scenario headings across the 10 references use a single blank line.
|
|
||
| ### Scenario B — OAuth token theft from analytics platform | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: extra blank line after the ### Scenario B heading, same as ref 07.
| @@ -0,0 +1,82 @@ | |||
| --- | |||
| title: 'OWASP CI/CD Top 10 Vulnerability Index' | |||
There was a problem hiding this comment.
Nit: the index title is single-quoted but has no special YAML characters. The individual reference titles (01-10) correctly use quotes because they contain colons, but this one could be unquoted for consistency with the other skills' index files.
| title: 'OWASP CI/CD Top 10 Vulnerability Index' | |
| title: OWASP CI/CD Top 10 Vulnerability Index |
Pull Request
Description
In alignment with phase 2 discussed in #480 (comment), this PR introduces the OWASP CICD Top 10 skill to hve-core and the security reviewer agent.
Related Issue(s)
Closes #1243
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
To be able to test the
owasp-cicdskill using the security reviewer agent you will need a repository containing cicd configuration.Security Revieweragent or invoke the agent via the/security-revewinstructionanalyse the code and produce a vulnerability reportcodebase-profiler.agent.mdpicks up that the repository contains cicd configuration (like github workflow) and thus uses theowasp-cicdskill then that's all you need.owasp-cicdis used, in your prompt addtargetSkill=owasp-cicdYou should see in the output report the
owasp-cicdskill being referenced and used.Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generateSecurity Considerations