Skip to content

feat(project-planning): ISA-95 network planner agent#1177

Open
nguyena2 wants to merge 16 commits intomainfrom
feat/networking-agent
Open

feat(project-planning): ISA-95 network planner agent#1177
nguyena2 wants to merge 16 commits intomainfrom
feat/networking-agent

Conversation

@nguyena2
Copy link
Copy Markdown

@nguyena2 nguyena2 commented Mar 23, 2026

Pull Request

Description

Created the ISA-95 network planning agent and updated collection references to the new path.

This PR also refreshed plugin linkage so the agent remains discoverable in bundled outputs.

Related Issue(s)

None

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Sample Prompts (for AI Artifact Contributions)

Execution Flow:

  1. User invokes the renamed planning agent via prompt or agent picker.
  2. Agent enforces intake gating for required ISA-95 context fields before classification.
  3. Agent maps zones/conduits, classifies alignment, and produces remediation priorities.
  4. Agent writes a markdown assessment and YAML companion artifact output.

Output Artifacts:

  • .copilot-tracking/reviews/{{YYYY-MM-DD}}-network-isa95-assessment.md (default path when caller does not provide one)

Preview:

# Output A: Plain-Language Assessment
## Current architecture summary
...

```yaml
assessment_metadata:
  ...

**Success Indicators:**
- Agent appears under the new name (`Network ISA-95 Planner`) in collections/plugin bundles.
- Invoking the agent uses the updated default output artifact naming (`network-isa95-assessment`).
- Collection manifests resolve the renamed path without stale references.

For detailed contribution requirements, see:

* Common Standards: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing
* Agents: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns
* Prompts: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables
* Instructions: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns
* Skills: [docs/contributing/skills.md](../docs/contributing/skills.md) - Task execution utilities with cross-platform scripts

## Testing
- Generated PR reference and reviewed diffs using `.copilot-tracking/pr/pr-reference.xml`.
- Verified changed files map to renamed agent + collection wiring.
- Performed security review of changed artifacts for sensitive data introduction; none found in committed files.
- Manual testing was not performed.

## Checklist

### Required Checks

* [ ] Documentation is updated (if applicable)
* [x] Files follow existing naming conventions
* [x] Changes are backwards compatible (if applicable)
* [ ] Tests added for new functionality (if applicable)

### AI Artifact Contributions
<!-- If contributing an agent, prompt, instruction, or skill, complete these checks -->
* [ ] Used `/prompt-analyze` to review contribution
* [ ] Addressed all feedback from `prompt-builder` review
* [ ] Verified contribution follows common standards and type-specific requirements

### Required Automated Checks

The following validation commands must pass before merging:

* [x] Markdown linting: `npm run lint:md`
* [x] Spell checking: `npm run spell-check`
* [x] Frontmatter validation: `npm run lint:frontmatter`
* [x] Skill structure validation: `npm run validate:skills`
* [x] Link validation: `npm run lint:md-links`
* [x] PowerShell analysis: `npm run lint:ps`
* [x] Plugin freshness: `npm run plugin:generate`

## Security Considerations
<!-- ⚠️ WARNING: Do not commit sensitive information such as API keys, passwords, or personal data -->
* [x] This PR does not contain any sensitive or NDA information
* [x] Any new dependencies have been reviewed for security issues (N/A — no new dependencies)
* [ ] Security-related scripts follow the principle of least privilege (N/A — no security scripts modified)

## Additional Notes
- Repository PR template from `.github/PULL_REQUEST_TEMPLATE.md` was used.
- This PR includes AI artifact changes; human review of agent behavior is recommended before merge.

…t requirements and visual walkthrough

- add markdown assessment file creation guidelines
- specify output paths and content structure
- include visual walkthrough requirements with Mermaid diagram
- improve clarity for non-experts with plain-language explanations

🔒 - Generated by Copilot
…d assumption handling

- add comprehensive intake question script for missing fields
- implement low-confidence assumption mode for unanswered items
- establish intake-gate-pending structure for incomplete intake
- clarify output requirements based on intake completeness

🔒 - Generated by Copilot
…5 Planner

- update references in collections and README files
- remove old agent file and create new one with updated name
- ensure consistency across documentation and plugin files

🔄 - Generated by Copilot
…ents documentation

🔒 - Generated by Copilot
@nguyena2 nguyena2 requested a review from a team as a code owner March 23, 2026 16:12
@nguyena2 nguyena2 changed the title feat(project-planning): rename ISA-95 network planner agent feat(project-planning): ISA-95 network planner agent Mar 23, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.65%. Comparing base (a18ab1a) to head (f8ac84d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   87.63%   87.65%   +0.01%     
==========================================
  Files          61       61              
  Lines        9328     9328              
==========================================
+ Hits         8175     8176       +1     
+ Misses       1153     1152       -1     
Flag Coverage Δ
pester 85.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

Dependency Review Summary

The full dependency review summary was too large to display here (3099KB, limit is 1024KB).

Please download the artifact named "dependency-review-summary" to view the complete report.

View full job summary

@katriendg
Copy link
Copy Markdown
Contributor

Thanks for your proposal of the new agent.

One thing I would like to raise here is a discussion on whether this agent makes much sense into the hve-core 'Project Planning' collection, or any of the existing collections for that matter. This agent is very domain-specific, while all other agents in the collection are intentionally agnostic.

My first reflection was whether this makes more sense in edge-ai repo? It can still link back to the Security Planner agent as long as edge-ai has pre-installed extension or guidance around it.

Thoughts?

@nguyena2
Copy link
Copy Markdown
Author

nguyena2 commented Mar 26, 2026

Thanks for your proposal of the new agent.

One thing I would like to raise here is a discussion on whether this agent makes much sense into the hve-core 'Project Planning' collection, or any of the existing collections for that matter. This agent is very domain-specific, while all other agents in the collection are intentionally agnostic.

My first reflection was whether this makes more sense in edge-ai repo? It can still link back to the Security Planner agent as long as edge-ai has pre-installed extension or guidance around it.

Thoughts?

Thanks for your proposal of the new agent.

One thing I would like to raise here is a discussion on whether this agent makes much sense into the hve-core 'Project Planning' collection, or any of the existing collections for that matter. This agent is very domain-specific, while all other agents in the collection are intentionally agnostic.

My first reflection was whether this makes more sense in edge-ai repo? It can still link back to the Security Planner agent as long as edge-ai has pre-installed extension or guidance around it.

Thoughts?

Bill and I briefly discussed where to put this as it could live in edge-ai or here. I decided to put it here as the intent is to be more general. The first pass is very edge-ai as it's what I used to build the agent off of. As we get more clarity on how this agent is used and how it evolves, we can always move it later.

Copy link
Copy Markdown
Member

@bindsi bindsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this agent´s clear structure and purpose to cover a difficult and very important domain for customers.
But I suggest to query more information in the intake process for the brownfield or greenfield scenarios. On the one hand for brownfield it might be relavent to reuse own (reverse) proxies, gateways, vpn, etc. and on the other hand for greenfield the target architecture might be relevant --> maybe be pointing to some Microsoft recommendations (like for AIO https://learn.microsoft.com/en-us/azure/iot-operations/manage-layered-network/concept-iot-operations-in-layered-network, https://github.com/Azure-Samples/explore-iot-operations/blob/main/samples/layered-networking/aio-layered-network.md), maybe we can also address them as a skill and reference those here in the agent.

@WilliamBerryiii
Copy link
Copy Markdown
Member

I really like this agent´s clear structure and purpose to cover a difficult and very important domain for customers. But I suggest to query more information in the intake process for the brownfield or greenfield scenarios. On the one hand for brownfield it might be relavent to reuse own (reverse) proxies, gateways, vpn, etc. and on the other hand for greenfield the target architecture might be relevant --> maybe be pointing to some Microsoft recommendations (like for AIO https://learn.microsoft.com/en-us/azure/iot-operations/manage-layered-network/concept-iot-operations-in-layered-network, https://github.com/Azure-Samples/explore-iot-operations/blob/main/samples/layered-networking/aio-layered-network.md), maybe we can also address them as a skill and reference those here in the agent.

Could also do what we did for the security planner and reference the WAF and CAF to fold in those default Azure Practices

nguyena2 added 4 commits April 7, 2026 10:31
…kills

- introduce ISA-95-aligned network planning assistant for secure edge Kubernetes to Azure connectivity
- add runtime lookup guidance for ISA-95 network planning across Azure IoT Operations layered networking, WAF, and CAF
- update collections to include new skills and agents

🔒 - Generated by Copilot
…d Network Azure Guidance skills

🔗 - Generated by Copilot
@nguyena2 nguyena2 requested a review from bindsi April 7, 2026 18:58
@nguyena2
Copy link
Copy Markdown
Author

nguyena2 commented Apr 7, 2026

I added more intake questions for both greenfield and brownfield scenarios. Moved the .md into its own networking folder since I do see it get more expansive in the future. Also added a skills .md to follow security, to help provide those default practices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants