[live-migration] adds the snapshot proto for the shim state#2711
Open
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Open
[live-migration] adds the snapshot proto for the shim state#2711rawahars wants to merge 1 commit intomicrosoft:mainfrom
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Conversation
As part of live migration workflow, we need to snapshot the current state of the shim and then restore the same at the destination side. This change adds the proto which is a well-typed structure for the shim state used during Save/Restore. Signed-off-by: Harsh Rawat <[email protected]>
4f6f8b5 to
dde22da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
internal/controller/migration/snapshot, a new package that defines the wire format used to hand off a running LCOW sandbox between shims during live migration.What's in this change
snapshot.proto— new protobuf schema describing a self-contained, point-in-time snapshot of an LCOW sandbox: the utility VM, its device sub-controllers (SCSI, VPCI, Plan9), per-pod network state, and the containers and processes running in the guest. The schema is versioned so that incompatible producers and consumers fail fast instead of silently corrupting state.snapshot.pb.go— generated Go bindings (produced viaprotobuild; seeProtobuild.toml).doc.go— package overview describing the migration use case, the controller-oriented layout, and the source/destination caller flow.Design notes
SandboxSnapshot.schema_versionis bumped whenever field semantics change; destinations must reject unknown versions.Stageenum mirrors the corresponding Go State iota in the controller it represents, with matching zero values so default-constructed messages map to the controllers' initial states.