fix(golang-mongodb-mongo-driver): add missing jmespath BuildRequires#16631
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 13, 2026
Merged
Conversation
The aws-sdk-go-devel bootstrap build has auto-generated Requires stripped, so it doesn't transitively pull in golang-github-jmespath-devel. Add an explicit BuildRequires on golang(github.com/jmespath/go-jmespath) to fix the build failure. Promoted from inline component to dedicated comp.toml for overlay support.
christopherco
force-pushed
the
chrco/fix-golang-mongodb-mongo-driver2
branch
from
2d4f239 to
8367361
Compare
christopherco
changed the title
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bootstrap-related build failure by explicitly adding the missing go-jmespath build dependency to the golang-mongodb-mongo-driver component via a targeted spec overlay, and moves the component from an inline entry to a dedicated *.comp.toml so overlays can be applied cleanly.
Changes:
- Add a
spec-add-tagoverlay to injectBuildRequires: golang(github.com/jmespath/go-jmespath)forgolang-mongodb-mongo-driver. - Promote
golang-mongodb-mongo-driverfrom an inline component entry to a dedicatedgolang-mongodb-mongo-driver.comp.toml. - Remove the now-redundant inline component stanza from
base/comps/components.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/golang-mongodb-mongo-driver/golang-mongodb-mongo-driver.comp.toml | Adds an overlay to explicitly declare the missing jmespath BuildRequires for bootstrap builds. |
| base/comps/components.toml | Removes the inline component entry now that a dedicated *.comp.toml exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anphel31
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aws-sdk-go-devel bootstrap build has auto-generated Requires stripped, so it doesn't transitively pull in golang-github-jmespath-devel. Add an explicit BuildRequires on golang(github.com/jmespath/go-jmespath) to fix the build failure.
Promoted from inline component to dedicated comp.toml for overlay support.