workaround(NetworkManager-libreswan): disable gtk4 plugin — gtk4 version too old#16629
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 13, 2026
Merged
Conversation
…ion too old libnma-gtk4 requires gtk4 >= 4.20.4 but the build tag only has 4.20.3. Disable the gtk4 VPN editor plugin until gtk4 is updated. The GTK3 GNOME editor plugin is still built. Build verified locally; RPM contents inspected in mock.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the GTK4 VPN editor plugin build for NetworkManager-libreswan as a temporary workaround for a gtk4/libnma-gtk4 version mismatch in the current build tag, while keeping the GTK3 editor plugin enabled.
Changes:
- Add a dedicated
NetworkManager-libreswan.comp.tomlto disable thegtk4build conditional (without = ["gtk4"]). - Remove the now-customized component from the “no per-component modifications” list in
components.tomlto avoid duplicate component tables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/NetworkManager-libreswan/NetworkManager-libreswan.comp.toml | Introduces per-component build config to disable the gtk4 bcond for this component. |
| base/comps/components.toml | Removes the inline component entry since it now has a dedicated *.comp.toml file (picked up via includes = ["**/*.comp.toml", ...]). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anphel31
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnma-gtk4 requires gtk4 >= 4.20.4 but the build tag only has 4.20.3. Disable the gtk4 VPN editor plugin until gtk4 is updated. The GTK3 GNOME editor plugin is still built.
Build verified locally; RPM contents inspected in mock.