Skip to content

Move Subcontracting Setup Fields To Manufacturing Setup (except wizard setup)#7100

Open
stevengrossGOB wants to merge 9 commits intomicrosoft:mainfrom
GOB-Software-Systeme-DevOps:w/grosss/SubcontractingSetup_FromMSMain
Open

Move Subcontracting Setup Fields To Manufacturing Setup (except wizard setup)#7100
stevengrossGOB wants to merge 9 commits intomicrosoft:mainfrom
GOB-Software-Systeme-DevOps:w/grosss/SubcontractingSetup_FromMSMain

Conversation

@stevengrossGOB
Copy link
Copy Markdown
Contributor

@stevengrossGOB stevengrossGOB commented Mar 11, 2026

Summary

This pull request refactors the subcontracting setup logic to use the Manufacturing Setup table instead of the Subc. Management Setup table for storing and retrieving most subcontracting-related configuration. This change centralizes subcontracting configuration, updates initialization routines, and modifies how various processes access setup data throughout the application.

Centralization of Subcontracting Configuration:

  • Replaced usage of Subc. Management Setup with Manufacturing Setup for storing and retrieving most subcontracting-related fields, such as template names, batch names, routing link codes, and handling times, across codeunits including initialization, purchase order creation, and process wizards. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Initialization and Setup Logic:

  • Updated the initialization procedure in Subcontracting Comp. Init. to create and configure the Manufacturing Setup record instead of Subc. Management Setup, and adjusted related helper procedures accordingly.

Process and Helper Function Updates:

  • Added new GetManufacturingSetup helper procedures and corresponding boolean flags in affected codeunits to cache and retrieve the Manufacturing Setup record, replacing previous logic that used Subc. Management Setup. [1] [2] [3] [4]

Field and TestField Adjustments:

  • Updated all relevant TestField and field access calls to reference fields in Manufacturing Setup (e.g., "Subcontracting Template Name", "Subc. Inb. Whse. Handling Time", "Rtng. Link Code Purch. Prov.", "Subc. Comp. at Location", etc.), and adjusted logic for handling missing or required configuration. [1] [2] [3] [4]

Namespace and Dependency Updates:

  • Updated using/import statements to include Microsoft.Manufacturing.Setup in all affected files to ensure access to the new centralized setup table. [1] [2] [3]

These changes collectively improve maintainability and consistency by consolidating subcontracting configuration into a single setup table.y

Work Item(s)

Fixes AB#618366

@stevengrossGOB stevengrossGOB requested a review from a team as a code owner March 11, 2026 15:37
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Mar 11, 2026
@github-actions github-actions bot added this to the Version 29.0 milestone Mar 11, 2026
@JesperSchulz JesperSchulz added the SCM GitHub request for SCM area label Mar 16, 2026
stevengrossGOB and others added 3 commits March 27, 2026 12:09
…units

- Eliminated unnecessary ManufacturingSetup record declarations
  from SubcTempDataInitializer, SubcCreateSubCReturnOrder,
  SubcLocationHandlerTest, and other libraries to improve code clarity.
- Added SubcManufacturingSetup.TableExt to extend Manufacturing Setup
  with new fields for subcontracting processes.
@stevengrossGOB
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="GOB"

if HasManufacturingSetup then
exit;
if ManufacturingSetup.Get() then
HasManufacturingSetup := true;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be one line - HasManufacturingSetup := ManufacturingSetup.Get();

@ChethanT ChethanT self-requested a review April 7, 2026 20:12
ChethanT
ChethanT previously approved these changes Apr 7, 2026
@stevengrossGOB stevengrossGOB dismissed stale reviews from ChethanT and AleksandricMarko via 10f62e1 April 8, 2026 05:52
Updated the assignment of HasManufacturingSetup in
SubcPurchaseOrderCreator, SubcontractingManagement, and
SubcTempDataInitializer codeunits for improved readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants