Move Subcontracting Setup Fields To Manufacturing Setup (except wizard setup)#7100
Open
stevengrossGOB wants to merge 9 commits intomicrosoft:mainfrom
Open
Conversation
…units - Eliminated unnecessary ManufacturingSetup record declarations from SubcTempDataInitializer, SubcCreateSubCReturnOrder, SubcLocationHandlerTest, and other libraries to improve code clarity. - Added SubcManufacturingSetup.TableExt to extend Manufacturing Setup with new fields for subcontracting processes.
Contributor
Author
|
@microsoft-github-policy-service agree company="GOB" |
ChethanT
requested changes
Apr 6, 2026
src/Apps/W1/Subcontracting/App/src/Setup/Tables/SubcManagementSetup.Table.al
Show resolved
Hide resolved
src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcPurchaseOrderCreator.Codeunit.al
Show resolved
Hide resolved
| if HasManufacturingSetup then | ||
| exit; | ||
| if ManufacturingSetup.Get() then | ||
| HasManufacturingSetup := true; |
Contributor
There was a problem hiding this comment.
nit: can be one line - HasManufacturingSetup := ManufacturingSetup.Get();
AleksandricMarko
previously approved these changes
Apr 7, 2026
ChethanT
previously approved these changes
Apr 7, 2026
10f62e1
…hub.com/GOB-Software-Systeme-DevOps/BCAppsGOB into w/grosss/SubcontractingSetup_FromMSMain
Updated the assignment of HasManufacturingSetup in SubcPurchaseOrderCreator, SubcontractingManagement, and SubcTempDataInitializer codeunits for improved readability.
ChethanT
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the subcontracting setup logic to use the
Manufacturing Setuptable instead of theSubc. Management Setuptable for storing and retrieving most subcontracting-related configuration. This change centralizes subcontracting configuration, updates initialization routines, and modifies how various processes access setup data throughout the application.Centralization of Subcontracting Configuration:
Subc. Management SetupwithManufacturing Setupfor storing and retrieving most subcontracting-related fields, such as template names, batch names, routing link codes, and handling times, across codeunits including initialization, purchase order creation, and process wizards. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Initialization and Setup Logic:
Subcontracting Comp. Init.to create and configure theManufacturing Setuprecord instead ofSubc. Management Setup, and adjusted related helper procedures accordingly.Process and Helper Function Updates:
GetManufacturingSetuphelper procedures and corresponding boolean flags in affected codeunits to cache and retrieve theManufacturing Setuprecord, replacing previous logic that usedSubc. Management Setup. [1] [2] [3] [4]Field and TestField Adjustments:
TestFieldand field access calls to reference fields inManufacturing Setup(e.g.,"Subcontracting Template Name","Subc. Inb. Whse. Handling Time","Rtng. Link Code Purch. Prov.","Subc. Comp. at Location", etc.), and adjusted logic for handling missing or required configuration. [1] [2] [3] [4]Namespace and Dependency Updates:
using/importstatements to includeMicrosoft.Manufacturing.Setupin all affected files to ensure access to the new centralized setup table. [1] [2] [3]These changes collectively improve maintainability and consistency by consolidating subcontracting configuration into a single setup table.y
Work Item(s)
Fixes AB#618366