merge fork main - #469
Merged
Merged
Conversation
added 5 commits
July 31, 2026 16:54
bls337
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching between Galvo and Stage scan recomputed the slice timing against the previous mode, so the first run after a switch failed validation and an immediate retry worked. The durations panel had the same problem and showed the other mode's numbers.
Fixing that exposed a second issue: the timing solver can produce a negative camera exposure, which the camera accepts without complaint and then images nothing. Added a check that refuses to arm instead of running it. These two belong together, since the first is what surfaces the bad value and the second is what catches it.
Also initializes the stage scan speed and acceleration before setup can exit early, so a refused run no longer restores 0 to the stage.
Bench-validated on a dual-Hamamatsu SCAPE: the mode switch no longer aborts, a valid stage scan still runs, and a refused one leaves the stage alone.