Skip to content

Camera layer fixes + stage scan speed restore - #461

Merged
bls337 merged 7 commits into
micro-manager:mainfrom
bls337:main
Jul 28, 2026
Merged

Camera layer fixes + stage scan speed restore#461
bls337 merged 7 commits into
micro-manager:mainfrom
bls337:main

Conversation

@bls337

@bls337 bls337 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Stage scan

  • fix stage scan speed restore, he "Max speed of X axis is small" prompt set the stage speed but not the value finish() restores, so the scan speed was written back at the end of every run and the prompt returned forever. 1.4 updates both,

Camera layer

  • restore camera library switch for pseudo-overlap, 1.4 branches per camera library here with a default: error for unrecognised ones. Both engines had lost it (SCAPE collapsed it to if (!PVCAM), diSPIM dropped it entirely), so any non-PVCAM camera silently got the PCO exposure formula.
  • read camera mode from settings, not camera readback, the engines asked the camera which trigger mode it was in, but that readback is lossy on PVCAM (pseudo-overlap reads back as edge trigger). 1.4 has no camera-mode getter at all, the settings are the only source. SCAPE already worked around this; diSPIM did not.
  • remove redundant implements LightSheetCamera, subclasses re-declared what CameraBase already implements.
  • make vendor camera methods abstract / add UnknownCamera, getResolution, getBinning, getReadoutTime, getResetTime, getRowReadoutTime and setBinning returned 0 or 0×0 on the base, so a camera class that omitted one inherited a plausible zero that fed straight into slice timing. They are now abstract. All five existing camera classes already implemented all six, so none needed changing.

@bls337
bls337 merged commit c6575fa into micro-manager:main Jul 28, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant