Let's improve everything: less spaghetti code, scan algorithm and CI improvement, lighter binary#55
Open
pandatix wants to merge 36 commits into
Open
Let's improve everything: less spaghetti code, scan algorithm and CI improvement, lighter binary#55pandatix wants to merge 36 commits into
pandatix wants to merge 36 commits into
Conversation
…endencies at each build, set properly env variables and use of linux filesystem
…actor project layout to match conventions + improve code
pandatix
changed the title
pandatix
changed the title
pandatix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, St******* told me about this repo. I saw Go. I was not able not to contribute. 😄
So here is my PR (he challenged me to do it the 6th of april sooooo). I let you check what is new (pretty much everything) in the code, but here is a summary:
internalat root)darwin/386build because is not compatible with Go 1.16)README.mdfor open-source contributionsIt also decreases the binary sizes with an average of -14,59%, according to the following.
darwin/386darwin/amd64freebsd/386freebsd/amd64freebsd/armlinux/386linux/amd64linux/armlinux/mipslinux/mips64linux/mips64lelinux/mipslelinux/s390xnetbsd/386netbsd/amd64netbsd/armopenbsd/386openbsd/amd64windows/386windows/amd64THE CLI IS NOT BACKWARD COMPATIBLE.