Repository navigation
Conversation
hanming5
force-pushed
the
366-telephone-field-stubs
branch
from
November 6, 2026 09:54
19474cc to
20ce1fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366
Adds a stub for
\Drupal\telephone\Plugin\Field\FieldType\TelephoneItemso itsvalueproperty is typed. This follows the same pattern as the PathItem stub in #1007.TelephoneItem::propertyDefinitions()declares a single requiredstringproperty (value), so the stub declares@property string $value, which matches the existingEmailItemstub.Changes
stubs/Drupal/telephone/Plugin/Field/FieldType/TelephoneItem.stubTelephoneItemintests/src/Type/data/field-types.phpTesting
php vendor/bin/phpunit: 892 tests pass (Drupal 11.4, PHP 8.3)php vendor/bin/phpcsandphp vendor/bin/phpstan analyze: no errorsFieldTypesTestfails on the new$telephone_field->valueassertion