Repository navigation
Keep drupal/core on the checkout in the core baseline job - #1067
Merged
Merged
Conversation
Drupal 12 packages no longer include tests, so core's PHPStan config fails on excludePaths entries that don't exist and the job never analyzes anything. See https://www.drupal.org/node/3618953 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
preferred-install has no effect here. drupal/core is first installed from core's path repository, and Composer keeps a dev package's installation source on update, so it still extracted the archive. Stop replacing core's repositories, so drupal/core stays on the checkout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mglaman
changed the title
Keeping core's path repository wasn't enough. Core's root composer.json no longer requires drupal/core-dev, so the bare require resolved to 8.0.0-beta15 and --with-all-dependencies updated 72 packages, including drupal/core. Only update the packages this job tests. Core's require-dev has the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mglaman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drupal core HEAD baseline checkfails before analyzing anything:As of Drupal 12.0.0,
drupal/corepackages don't include tests (change record). The job'scomposer requirestep replaces the core checkout with that package, so the paths incore/phpstan.neon.distno longer exist.Two changes keep
drupal/coreon the checkout:repositories.0andrepositories.1were overwriting core'scoreandRecipeUnpackpath repositories.composer require. Core's rootcomposer.jsonno longer requiresdrupal/core-dev, so the bare require resolved to8.0.0-beta15, and--with-all-dependenciesthen updated 72 packages, includingdrupal/core. Core'srequire-devalready has what this job needs, so only update PHPStan,phpstan-phpunit, and our package.What didn't work
The earlier commits on this branch each failed in CI, with
Extracting archivestill in the log:preferred-install.drupal/core source, which the change record recommends.drupal/coreis first installed from the path repository, andDownloadManager::getAvailableSources()keeps a dev package's installation source on update.--with-all-dependenciesupdate still replaceddrupal/core.Testing
Ran the Composer step as a dry run against a clone of core's
main:drupal/corebc43a39, matching CI7fa85d2from the path repositoryThat covers dependency resolution only. This PR's run of the job is the test for the rest. It should now reach analysis and may report real errors: before the packaging change it was failing on analysis errors. It's
continue-on-error, so those don't block merging.🤖 Generated with Claude Code