Repository navigation
Ignore ResultCacheMetaExtension deprecation in our own analysis - #1065
Merged
Merged
Conversation
PHPStan 2.3 deprecates the interface. Its replacement requires 2.3 and we support ^2.1, so migrating is a separate decision tracked in #1061. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan 2.3 deprecates
ResultCacheMetaExtension.BootstrapResultCacheMetaExtensionimplements it, sophpstan analyzefails in our lint job. The scheduled run has been red since 2026-10-07, and every PR's lint job fails the same way.Ignore the error for that one file. The replacement API (
$scope->trackFileDependency()and friends) requires PHPStan 2.3 and we allow^2.1, so migrating means raising the floor. #1061 tracks that decision. The deprecation doesn't reach users: it only reports on our own source.Merge order
Lint stays red on this PR until #1064 lands, because that PR fixes the other error (
foreach.valueOverwrite). Merge #1064 first, then re-run this PR's checks.Testing
Run with PHPStan 2.3.5, strict-rules 2.1.1, and deprecation-rules 2.0.5, the versions CI installs:
main: 2 errors, matching CIforeach.valueOverwriteIntegration jobs depend on lint, so they haven't run since 2026-10-06. They'll run on PHPStan 2.3 for the first time once lint passes here.
🤖 Generated with Claude Code