Feature/116 news context - #117
Open
KarlsonComplete wants to merge 15 commits into
Open
Conversation
…n invalid mobilePhone.
…-install-contact-person-mobile-phone-validation Fixed issue mesilov#111 (InstallContactPerson не должен прерывать сохранение contact person из-за невалидного mobilePhone)
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
camaxtly
requested changes
Jul 26, 2026
- Removed the `archive` method and the "archived" status from the `News` entity. - Deleted `Command`, `Handler`, `NewsArchivedEvent`, and relevant test cases. - Updated repository interface and documentation to reflect the removal of the archive functionality.
- Introduced `imageUrl` field to the `News` entity and updated mapping. - Added methods to attach, detach, and validate image URLs with corresponding events. - Updated `Create` and `Update` use cases to handle optional `imageUrl`. - Implemented unit and functional tests for image-related functionality.
- Introduced `NewsNotFoundException` and corresponding error handling across `Delete`, `Update`, `Publish`, and `RevertToDraft` use cases. - Enhanced logging with clear success, failure, and finishing states for all `News` actions. - Added and updated tests to validate `NewsNotFoundException` handling. - Refactored `News` and related test code for consistent variable naming (`news` to `newsItem`).
- Updated the `findByTitle` method in the `NewsRepository` to filter out deleted news. - Adjusted repository interface and documentation to reflect this change. - Refactored functional tests to use a reusable `entityManager` instance.
…lated tests - Moved `imageUrl` initialization to the constructor for consistency. - Removed unnecessary `attachImage` usage in `Create` and `Builder` implementations. - Added and updated test cases for `imageUrl` functionality, including attachment, detachment, and validation.
- Added `imageUrl` field to `News` entity and updated mapping to include nullable string. - Adjusted domain events and acceptance criteria to incorporate `imageUrl` changes. - Removed `archived` status and related functionality; updated `NewsStatus` enum and transitions. - Refined repository methods (`getById`, `findPublished`, `findDrafts`) and adjusted query handling for clarity. - Updated unit and functional tests to cover new `imageUrl` logic and refined UseCases. - Updated documentation and changelog for version 0.8.0 changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.