Fix sub story count cache column not up to date - #4
Open
geralddzx wants to merge 53 commits into
Open
Conversation
We were checking `persisted?`, which is always true in an `after_save` callback.
Mavenlink upgrades
Add an ancestry_depth query
…ot_ancestor` association if enabled
…butes that needs updating when ancestry changes
Add option to enable `root_ancestor` relation
Rails4 Compatability
…n a child node is made a root
…Record-3.1 in Ruby 1.9.3
…el_stories Update root_ancestor_id of descendants when parent is made a root
The current behavior is that a new record will have all stories in the entire database as descendants - Rick and Gerald
Owner
|
Wow ... that is quite the PR! Looks like you folks have been using and improving arboreal for a couple of years. I'd like to merge in your work, but there's simply too much going on here for me to review. I note there are also a few commits that alter behaviour, without accompanying tests. Could you break your fork into separate PRs, so we can look at merging it incrementally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.