Fix: Pattern link edge labels swapped in model-transformation diagrams#13
Draft
amirrza777 wants to merge 1 commit into
Draft
Fix: Pattern link edge labels swapped in model-transformation diagrams#13amirrza777 wants to merge 1 commit into
amirrza777 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a diagram rendering bug where pattern link edge end labels were assigned to the wrong end, and adds an initial CSV import pipeline that infers a metamodel/model pair from CSV text and exposes it via a backend endpoint.
Changes:
- Corrected
addPatternLinkLabelsend-tagging so source/target edge labels attach to the correct edge end. - Added
CsvModelInference(metamodel module) plus unit tests for CSV parsing and type inference. - Added backend CSV import service + route, wiring it into DI and adding the metamodel module dependency; adjusted workbench Docker build memory.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| platform/metamodel/src/test/kotlin/com/mdeo/metamodel/csv/CsvModelInferenceTest.kt | Adds unit tests covering CSV parsing, type inference, optionality, enums, and header sanitization. |
| platform/metamodel/src/test/kotlin/com/mdeo/metamodel/csv/CsvModelInferenceManualRun.kt | Adds a manual-run test harness for printing inferred metamodel/model from a CSV file. |
| platform/metamodel/src/main/kotlin/com/mdeo/metamodel/csv/CsvModelInference.kt | Implements CSV parsing + inference to produce MetamodelData and ModelData. |
| platform/common/src/main/kotlin/com/mdeo/common/model/ApiResult.kt | Adds an error code for CSV import failures. |
| platform/backend/src/main/kotlin/com/mdeo/backend/service/InjectedServices.kt | Extends injected services with csvImportService. |
| platform/backend/src/main/kotlin/com/mdeo/backend/service/CsvImportService.kt | Implements backend CSV→(metamodel, model) import and writes results into project files. |
| platform/backend/src/main/kotlin/com/mdeo/backend/routes/CsvImportRoutes.kt | Exposes POST /api/projects/{projectId}/csv-import with permission checks. |
| platform/backend/src/main/kotlin/com/mdeo/backend/Application.kt | Registers CsvImportService and routes in the backend module wiring. |
| platform/backend/build.gradle.kts | Adds :metamodel dependency to backend for CSV inference usage. |
| infra/docker/workbench/Dockerfile | Increases Node heap during workbench build to reduce build-time OOM. |
| app/packages/language-model-transformation/src/features/diagram-server/modelTransformationGModelFactory.ts | Swaps pattern link end label .end(...) values to fix swapped/missing labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+11
| @Test | ||
| fun `print inferred metamodel and model for a real csv file`() { |
Comment on lines
+59
to
+64
| val properties = mutableListOf<PropertyData>() | ||
| val enums = mutableListOf<EnumData>() | ||
|
|
||
| header.forEachIndexed { colIndex, rawColumnName -> | ||
| val propertyName = sanitizePropertyName(rawColumnName, fallback = "column${colIndex + 1}") | ||
| val values = columns[colIndex] |
Comment on lines
+141
to
+146
| val distinctValues = nonBlankValues.distinct() | ||
| val isRepeated = distinctValues.size < nonBlankValues.size | ||
| if (distinctValues.size <= enumMaxDistinct && isRepeated) { | ||
| val enumName = propertyName.replaceFirstChar(Char::uppercaseChar) + "Enum" | ||
| return ColumnType.Enum(enumName, distinctValues.map { sanitizeEnumEntry(it) }) | ||
| } |
Comment on lines
+31
to
+33
| val normalizedBasePath = basePath.trim().trim('/') | ||
| val metamodelPath = "$normalizedBasePath.metamodel" | ||
| val modelPath = "$normalizedBasePath.model" |
Member
|
Many thanks, @amirrza777. I notice that this PR also includes some files related to CSV import, which is unrelated to the issue that the PR aims to fix. Could you separate these out to make for a cleaner PR? |
Member
|
I just noticed that this seems to be intentional. I would recommend ensuring that each PR maps to exactly one issue that it solves rather than trying to solve multiple issues in one PR. That makes reviewing PRs much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Related to #12
Changes
Bug fix — edge label swap (#11)
.end()values inaddPatternLinkLabelsinmodelTransformationGModelFactory.ts"source", target property label tagged"target"Feature — CSV model import (#12)
CsvModelInferencein themetamodelmodule: infers a metamodel and model from a CSV file (type detection: int, double, boolean, enum, string; one class per file, one property per column, one instance per row)CsvImportServiceandCsvImportRoutesin the backend:POST /api/projects/{projectId}/csv-importaccepts a CSV file and writes the resulting.metamodeland.modelfiles into the projectStatus