Conversation
…lement/hamt-root-owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small RAII owner that always keeps a HAMT snapshot root paired with the block source that allocated it. This makes snapshot ownership explicit and prevents release through the wrong allocator domain.
AG;DR
This change adds
HamtRootOwner, a move-only internal owner for an immutable HAMT root and its originatingBlockSource.The owner:
HAMT_STORAGE.md.Validation on synchronized head
6c17d353e:bazel test //mbo/container:hamt_root_owner_testbazel test --noshow_progress //...(166 pass, one intentional exception-policy skip)bazel test --config=clang --config=asan --config=asan-macos //mbo/container:hamt_root_owner_testgit diff --checkThe first remote clang-tidy run identified const-correctness, static-helper, and intentional moved-from-state diagnostics in the new test. The follow-up commit applies the mechanical const/static fixes and documents narrowly suppressed moved-from checks where the specified post-move contract itself is under test.
Focused LLVM coverage compilation was attempted locally, but the pinned LLVM linker cannot parse the host Command Line Tools SDK's newer
arm64e.x1TAPI architecture. The pull request's Ubuntu Clang coverage job is therefore the authoritative coverage validation. No production coverage exclusions, scope changes, or baseline changes are included.