Conversation
…into implement/hamt-replace
…into implement/hamt-replace
…into implement/hamt-replace
…ment/hamt-replace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add persistent replacement of a general HAMT entry without modifying the
original snapshot. Callers can update a stored value while preserving shared
sibling branches and recover cleanly when the block source is exhausted.
AG;DR
implement/hamt-clone). Keep theimplementation stack unmerged; this is not approval to merge a green draft.
TryReplaceHamtEntryborrows the original root and returns an optional owningroot/changed result. Null roots and missing keys succeed unchanged without
allocation; a non-null unchanged root is retained for the returned owner.
collisions. Unchanged siblings remain shared. The replacement must preserve
the original key and full routing hash; this is an internal precondition,
not a public API for changing keys in place.
outlive returned nodes; each successful owning root needs a matching release
through that source. The supplied source must be the original tree's block
source: retained siblings are not migrated into a different allocation domain.
Use independent cloning for cross-source migration. Existing immutable-tree
lifetime contracts still apply.
original snapshot could be released. Child-copy or parent-copy exhaustion
releases partial results and leaves original values and ownership unchanged.
aliasing, child-copy failure, and cleanup after a child copy succeeds but its
parent allocation fails. The fixture preserves GoogleTest's protected
TearDownvisibility and marks its stateless lookup helper static. UsesC++20-compatible code.
a233cfc06contains Add independent HAMT tree cloning with bounded rollback #471's fully green head. Post-pushvalidation passes
bazel test //...(165 passed, one intentionally skipped),focused macOS Clang ASAN/UBSAN, focused Clang coverage, and focused repository
checks. Coverage uses the repository's macOS system-linker configuration because
the hermetic
ld64.lldcannot parse the current SDK'sarm64e.x1TAPI records.This PR's own CI must pass before advancing its child; ancestor checks do not
substitute for this PR's checks.
claims. Final measurements/charts follow completion of implementation and
own-context validation. Initial host decisions are provisional; AMD Zen 5
remains explicitly later follow-up.