Open
Conversation
The pinned SHA for actions/cache v5.0.4 contained a typo (6682284cc58b73e9e0655991c2e8e82e47791b2a) that shares its first eight hex chars with the real SHA but otherwise differs, so GitHub Actions failed to resolve the action at workflow run time. Replace with the actual v5.0.4 SHA from upstream. Verified by querying repos/actions/cache/git/refs/tags/v5.0.4 on github.com.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
ruby/setup-ruby with bundler-cache=true installs gems into a Bundler-managed location whose bin directory is exposed via 'bundle exec', not added to PATH. The 'run: make' step in the workflow spawns its own /bin/bash, so kramdown-rfc was unfound. Wire 'bundle exec' into the KRAMDOWN_RFC variable so plain 'make' works in both CI and local devenvs without requiring developers to remember 'bundle exec make'. Override via the variable if invoking a globally installed kramdown-rfc. xml2rfc is left as a bare command because actions/setup-python adds its bin directory to PATH directly.
klp2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to get the GitHub Pages build green.
actions/cacheSHA typo. The pinned SHA forv5.0.4(6682284cc58b73e9e0655991c2e8e82e47791b2a) shares its first eight hex chars with the real SHA but otherwise differs, so GitHub Actions can't resolve it. Replace with the actualv5.0.4SHA from upstream (668228422ae6a00e4ad889ee87cd7109ec5666a7). Verified viarepos/actions/cache/git/refs/tags/v5.0.4on github.com. All other workflow SHAs were verified and are correct.kramdown-rfcnot found bymake.ruby/setup-rubywithbundler-cache: trueinstalls gems into a Bundler-managed location exposed viabundle exec, not onPATH. Therun: makestep spawns its own/bin/bash, so the gem binary isn't found. Wirebundle execinto the Makefile'sKRAMDOWN_RFCvariable so plainmakeworks in both CI and local devenvs.xml2rfcis left bare sinceactions/setup-pythonputs it on PATH directly.Test plan
Build Draftsstep resolvesactions/cacheand runs to completion.kramdown-rfcis invoked successfully viabundle exec.mainsucceeds and Pages deploy publishes.🤖 Generated with Claude Code