policyeval/commands: Automatically offer to protect space children - #74
Open
timedoutuk wants to merge 3 commits into
Open
policyeval/commands: Automatically offer to protect space children#74timedoutuk wants to merge 3 commits into
timedoutuk wants to merge 3 commits into
Conversation
Contributor
|
Does it make sense to only protect rooms that also claim that space as canoncical parent via |
Collaborator
Author
|
There's no way to know if the space is canonical for the child without first joining the child, which means that detection would be spotty at best (i.e. requires the server is already in the room and it is world readable, or simply requires auto-joining every room in the space pre-emptively). Since the protection isn't done automatically (only offered), and instead requires manual button pushing, I assume people will only protect rooms they actually want to protect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
When a space is discovered via
!protect, the hierarchy will be inspected to list up to 100 unprotected rooms. The bot will then offer to protect those rooms through the reaction menu.This implicitly allows "spidering" a space, as when a subspace is protected through these buttons, it will trigger the same child protection menu.
The other option I considered while designing this was a
--recursiveflag, which would make Meowlnir walk the hierarchy entirely and automatically protect any room it could join and had power level in, however I figured that might be too naive of an algorithm and explicit is better.Either way, this solves the issue I had where each of our rooms had to be manually protected after upgrading every single room and space in the community. It might be a bit hacky but 🤷♀️
Checklist