MM-68216 - add docs about team scoped channels abac#8854
MM-68216 - add docs about team scoped channels abac#8854
Conversation
|
Newest code from mattermost has been published to preview environment for Git SHA 7b48897 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds documentation and permissions for a new team-level ABAC feature enabling Team Admins to create and manage attribute-based membership policies for private channels within their team; updates ABAC overview, team settings and role docs, and introduces the Changes
Sequence Diagram(s)sequenceDiagram
participant TeamAdmin as Team Admin
participant UI as Team Settings UI
participant AppServer as Application Server
participant PolicyStore as Policy Store
participant SyncJob as Membership Sync Job
participant SystemPolicy as System-wide Policy Engine
TeamAdmin->>UI: Open Membership Policies tab
UI->>AppServer: Request team policies (check ABAC enabled + permission)
AppServer->>PolicyStore: Fetch team policies for team
PolicyStore-->>AppServer: Return policies
AppServer-->>UI: Render policies list
TeamAdmin->>UI: Create/Edit policy + assign private channels
UI->>AppServer: Submit policy (validate permission)
AppServer->>SystemPolicy: Validate no conflict with system-wide policies
SystemPolicy-->>AppServer: Validation result
AppServer->>PolicyStore: Save policy and channel assignments
PolicyStore-->>AppServer: Ack
AppServer-->>UI: Confirm save
AppServer->>SyncJob: Trigger immediate sync for affected channels
SyncJob->>PolicyStore: Read applicable system + team policies
SyncJob->>PolicyStore: Evaluate membership changes (apply auto-add, removals)
SyncJob-->>AppServer: Sync complete
AppServer-->>UI: Notify TeamAdmin of completion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Newest code from mattermost has been published to preview environment for Git SHA 79b2d9d |
isacikgoz
left a comment
There was a problem hiding this comment.
Looks good overall but one correction is needed. Also one thing to confirm.
source/administration-guide/manage/admin/abac-team-channel-policies.rst
Outdated
Show resolved
Hide resolved
source/administration-guide/manage/admin/abac-team-channel-policies.rst
Outdated
Show resolved
Hide resolved
|
Newest code from mattermost has been published to preview environment for Git SHA 8e41512 |
|
Newest code from mattermost has been published to preview environment for Git SHA 2add867 |
isacikgoz
left a comment
There was a problem hiding this comment.
Looks good, just one correction needed, since it's a small one approving and leaving to you to fix before merge.
|
|
||
| .. note:: | ||
|
|
||
| System Admins also have access to the **Membership Policies** tab in Team Settings and can see all policies for the team, including those that span multiple teams. |
There was a problem hiding this comment.
I think this also needs to be updated, they are seeing what a regular team admin can see.
|
Newest code from mattermost has been published to preview environment for Git SHA 77998b0 |
|
Newest code from mattermost has been published to preview environment for Git SHA 66c1791 |
|
This is a nice doc @pvev :) |
|
Same note about rebasing to the right docs branch. If this is v11.7 the branch will be cut in the next few days @pvev |
|
Newest code from mattermost has been published to preview environment for Git SHA 9690760 |
|
Newest code from mattermost has been published to preview environment for Git SHA b280c27 |
Summary
This PR adds documentation for the team-level channel membership policies feature introduced as part of the ABAC phase 2 work. It covers how Team Admins create and manage attribute-based access policies for private channels within their team from Team Settings, including the new manage_team_access_rules permission. Existing ABAC and roles docs are updated to reflect the new three-tier hierarchy and cross-link to the new page.
Ticket Link
https://mattermost.atlassian.net/browse/MM-68216