Add edit command to notes CLI - #158
Open
volodymyrlp wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
edit <id> <text>command to the notes CLI.lib/store.js: newedit(id, text)— looks up a note by id and replaces its textnotes.js: newcase "edit"wired tostore.edit, plus updated help textmainhas been merged in to resolve thelib/store.jsadd/add conflictTry it
Review note
This branch carries a deliberately planted bug for the Lesson 4 exercise:
edit()does not check that the looked-up note exists, sonode notes.js edit <unknown-id> ...throwsTypeError: Cannot set properties of undefined.remove()right above it handles the missing-id case. Left in place intentionally — see the review comments on the fork PR (#1).