Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional browser E2E coverage around playlist creation/renaming/grouping, and introduces stable data-testid hooks + richer database mocking to support those flows.
Changes:
- Added a new Playlists E2E test and refactored common navigation/scan steps into shared helpers.
- Added
data-testidattributes to key UI elements used by E2E tests (playlist CTA/new button, rename input, sidenav letter headers). - Enhanced the database bridge mock to support basic playlist CRUD used by the UI during E2E runs; updated translation reference line numbers accordingly.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/playlists.test-e2e.tsx | New E2E test covering playlist empty state, creation, rename, and grouping behavior. |
| src/tests/test-helpers.tsx | Adds reusable navigation + library scan helpers for E2E tests. |
| src/tests/library.test-e2e.tsx | Uses new helpers to reduce repetition in library E2E tests. |
| src/tests/player.test-e2e.tsx | Uses new helpers to reduce repetition in player E2E test. |
| src/routes/playlists.tsx | Adds test IDs for playlist creation CTA and the “new playlist” button. |
| src/elements/ButtonIcon.tsx | Allows passing through a data-testid to the underlying <button>. |
| src/components/SideNavLink.tsx | Adds a test ID for rename input and enables rename via double-click for playlist items. |
| src/components/SideNav.tsx | Adds a test ID to letter group headers for assertions. |
| src/lib/mocks/bridge-database.ts | Adds in-memory playlist support for E2E (get/create/rename/setTracks/delete). |
| src/translations/*.po | Updates extracted source references to match shifted line numbers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martpie
force-pushed
the
playlists-e2e-tests
branch
from
d70c8db to
ae3e238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.