Repository navigation
Raise ValidationError for overflowing datetime inputs - #3107
Open
keshtib07-ghost wants to merge 2 commits into
Open
keshtib07-ghost wants to merge 2 commits into
keshtib07-ghost wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed datetime inputs can raise
OverflowErrorinstead ofValidationError. This affects RFC dates with oversized components and integer POSIX timestamps too large to convert to a float.For example:
The error also escapes through
Schema.load()andSchema.validate(), bypassing normal validation-error handling.Expected behavior:
Schema.load()raisesValidationErrorwith the affected field’s error message.Schema.validate()returns the field’s error dictionary.ValidationErrorwith"Not a valid datetime.".The existing exception handler in
_TemporalField._deserializetranslates several parsing exceptions into validation errors but does not catchOverflowError. This change includes it in that handler.Adds 18 regression cases covering:
rfcandrfc822.DateTime,NaiveDateTime, andAwareDateTime.timestampandtimestamp_ms.Schema.load()andSchema.validate().Also adds a changelog entry.
Validation on Python 3.12: