Skip to content

fix(editor): make heading marker hiding opt-in - #590

Merged
murongg merged 1 commit into
v2from
fix/580-heading-marker-setting
Jul 27, 2026
Merged

fix(editor): make heading marker hiding opt-in#590
murongg merged 1 commit into
v2from
fix/580-heading-marker-setting

Conversation

@murongg

@murongg murongg commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace the broad Markdown marker reveal preference with an opt-in heading marker hiding preference
  • keep the setting disabled by default and limit its behavior to heading markers only
  • preserve the existing full reveal behavior for inline formatting markers
  • migrate the beta.6/beta.7 reveal preference by inverting its stored value
  • update the setting copy across all supported locales to describe the Typora-like behavior

Why

The setting added in #582 affected both headings and inline formatting, while #580 only targets the visual shift caused by heading markers. Expressing the setting as automatic hiding also makes the switch direction match the behavior users enable.

Validation

  • pnpm --filter @markra/editor test — 351 tests passed
  • pnpm --filter @markra/app test -- src/components/CodeMirrorPaperSurface.test.tsx src/components/settings/EditorSettings.test.tsx src/lib/settings/editor-preferences.test.ts src/lib/settings/settings-events.test.ts src/hooks/useEditorPreferences.test.tsx — 100 tests passed
  • pnpm --filter @markra/shared test -- src/i18n/index.test.ts — 5 tests passed
  • pnpm typecheck:test — passed
  • pnpm build — passed, including desktop vendor chunk verification

Risk

  • existing beta.6/beta.7 preferences are migrated with inverted boolean semantics so the effective user choice is preserved
  • inline formatting and link marker reveal behavior remain unchanged

Refs #580
Follow-up to #582

Keep inline formatting marker reveal unchanged and migrate the legacy reveal preference to the inverted heading-only setting.

Refs #580
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 27, 2026 4:57am

@murongg
murongg merged commit 33a355e into v2 Jul 27, 2026
21 checks passed
@murongg
murongg deleted the fix/580-heading-marker-setting branch July 27, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant