feat(app): unify default fonts across platforms - #586
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--font-uitokenWhy
The previous system font stack resolved to different typefaces on macOS, Windows, and Linux. Shipping one variable font gives the app and default editor a consistent cross-platform typographic baseline while keeping theme-specific and user-selected editor fonts intact.
Validation
corepack pnpm --filter @markra/app exec vitest run src/styles.test.ts src/lib/editor-font.test.ts— 60 tests passedcorepack pnpm --filter @markra/editor exec vitest run --environment jsdom --globals src/codemirror/code-block.test.ts src/codemirror/frontmatter-preview.test.ts— 35 tests passedcorepack pnpm --filter @markra/desktop build— passed, including vendor chunk verificationcorepack pnpm --filter @markra/web build— passedRisk