Skip to content

fix(app): isolate editor mode changes by tab - #585

Merged
murongg merged 5 commits into
v2from
fix/editor-mode-tab-isolation
Jul 26, 2026
Merged

fix(app): isolate editor mode changes by tab#585
murongg merged 5 commits into
v2from
fix/editor-mode-tab-isolation

Conversation

@murongg

@murongg murongg commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • route visual and source editor updates to the tab that produced them
  • snapshot pending visual Markdown before source or split surfaces mount
  • isolate source editor instances and pending shared-history baselines by document
  • run CI for v2 pull requests and forward frontend test arguments correctly under pnpm 10
  • add asset cleanup messages for every supported locale and align titlebar layout assertions

Why

Delayed IME completion and reused editor state could write through the currently active document after a tab or editor-mode switch. That could make source mode display or update content from the wrong tab.

Enabling CI for v2 also exposed missing localized asset-cleanup messages and stale titlebar expectations. The pnpm 10 test invocation forwarded an extra separator to Vitest, causing every App shard to run the complete test suite instead of its assigned files.

Validation

  • targeted editor-mode and tab-isolation tests passed: 12 tests
  • manual Tauri QA passed across preview, source, split, and two-tab round trips
  • App workspace shards passed: 108 and 121 tests
  • App remaining shards passed: 725 and 447 tests across 62 files each
  • CodeMirror editor target passed: 33 tests in 1 file
  • shared tests passed: 62 tests
  • repository test typecheck passed
  • app and shared builds passed
  • diff checks passed

Risk

  • source CodeMirror instances now remount when the active document changes; existing per-tab view-state restoration remains responsible for restoring editor position
  • CI test commands now depend on pnpm forwarding matrix arguments directly without an extra separator

@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 26, 2026 11:57am

@murongg
murongg merged commit 0dbf56c into v2 Jul 26, 2026
21 checks passed
@murongg
murongg deleted the fix/editor-mode-tab-isolation branch July 26, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant