ci: add a ci-gate job as the single required status check - #10
Closed
mark-brannan wants to merge 3 commits into
Closed
ci: add a ci-gate job as the single required status check#10mark-brannan wants to merge 3 commits into
mark-brannan wants to merge 3 commits into
Conversation
The branch ruleset needs one context to require. Requiring the matrix legs directly means a renamed or dropped leg silently changes what is enforced, and a required context that never reports blocks every pull request. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodeQL flags a job that does not limit GITHUB_TOKEN. This one reads nothing and writes nothing -- its verdict comes from `needs` -- so the right scope is no permissions at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The comment conflated two different skips. A job skipped by `if` reports `skipped`; a workflow skipped by path or branch filters leaves its check pending. Neither is the explicit verdict a ruleset needs, which is the reason for `always()` -- not the "never reports" story the comment told. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Folded into #9, which now carries the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one
ci-gatejob that fans in this workflow's PR jobs, so the branch ruleset can require a single context.Requiring the matrix legs directly is brittle: rename or drop one and the ruleset silently enforces something different, or waits forever on a context that never reports.
always()is there so a skipped dependency fails the gate rather than skipping it.Groundwork for branch protection plus Mergify auto-update across the repos — mirrors
signalk-noaa-space-weather.🤖 Generated with Claude Code