circus-evaluator: evaluate flakes via canonical forge ref - #131
Merged
Conversation
NotAShelf
marked this pull request as draft
June 27, 2026 15:23
NotAShelf
force-pushed
the
notashelf/push-twvrxzrrwqsk
branch
from
July 19, 2026 10:08
89486d6 to
c780368
Compare
NotAShelf
marked this pull request as ready for review
July 19, 2026 10:09
NotAShelf
changed the title
NotAShelf
force-pushed
the
notashelf/push-twvrxzrrwqsk
branch
2 times, most recently
from
July 19, 2026 10:56
a500010 to
decc974
Compare
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I63482088397f090cc27ac70944579e626a6a6964
NotAShelf
force-pushed
the
notashelf/push-twvrxzrrwqsk
branch
2 times, most recently
from
July 23, 2026 18:46
052532f to
9892a03
Compare
amaanq
requested changes
Jul 24, 2026
NotAShelf
force-pushed
the
notashelf/push-twvrxzrrwqsk
branch
from
July 29, 2026 13:36
4808545 to
ee8bd00
Compare
…origin Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I13b7bad6502859a58b47901a1ebeb31f6a6a6964
NotAShelf
force-pushed
the
notashelf/push-twvrxzrrwqsk
branch
from
July 29, 2026 13:46
ee8bd00 to
64afee8
Compare
amaanq
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed how canonical flake sources are resolved and passed through the evaluator, to try and fix #130 and also to guarantee better reproducibility for hash-matching. This might explain why @atagen has experienced binary cache misses earlier. The legacy(tm( logic for constructing git flake references from local paths has been removed.
Arguably this is not the cleanest approach, but we are somewhat severely restricted by the underlying C API Evix calls for evaluations. I've tried to harden locking and evaluation as much as possible for v2, but I will investigate further. Still, this should fix the issue described in #130.
TODO: migrate host & flakeref parsing into a standalone crate that nh can use as well.
Change-Id: I63482088397f090cc27ac70944579e626a6a6964