Fix parsing top-level number, close #13#32
Open
kchanqvq wants to merge 1 commit into
Open
Conversation
Author
|
Hi, is this library still maintained? Can someone take a look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this great package! This is my attempt at addressing #13. I'm happy to discuss improvements needed for this patch! Maybe we can work on taking care of other edge cases as well? (e.g. top-level empty objects). Meanwhile, are we worried about any cost (wrt performance) for these handling? I suspect this impact is minimal, but I can write a macro that generate two top-level and non-top-level version as well to eliminate any difference...