Fix incorrect rs2 register read enable for immediate (OP_IMM) instructions#2394
Closed
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Closed
Fix incorrect rs2 register read enable for immediate (OP_IMM) instructions#2394Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Conversation
Contributor
|
We are closing this PR as the proposed changes do not align with our current development priorities, address any tracked issues, or meet our required technical standards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect rs2 read enable for OP_IMM instructions.
OP_IMM instructions only use rs1 and an immediate, so enabling rs2 is unnecessary.
This change ensures rf_ren_b_o is deasserted, improving decoder correctness and avoiding redundant register access.
Includes a simple testbench for validation.