Repository navigation
Conversation
Add --composition to the showcase, which composes its window around an empty native surface as one embedding a webview does, and report the time spent presenting each frame (LayoutStats::present_time), which with composition includes splitting the scene per surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--compositionto the showcase, which composes its window around an empty native surface as one embedding a webview does, and reports the time spent presenting each frame (LayoutStats::present_time, test-support only). With composition, presenting includes splitting the scene per surface.This answers whether enabling window composition (as Allsum does for its webview) makes drawing slower: run the showcase with and without
--compositionand compare thepresentcolumn.fast/composition.rstimespresent_scene();fast/stats.rsaddspresent_timeandFramePhaseTimes::add_present.gpui_perfshowcase:--compositionflag,presentcolumn in the report.script/check-upstream: 0 violations.cargo test -p gpui --features test-support --lib fast::andcargo test -p gpui_perfpass.🤖 Generated with Claude Code