input: add lsp provider setters; setters set _pending_update so LSP refreshes on next render#2491
Open
ScottCUSA wants to merge 1 commit into
Open
input: add lsp provider setters; setters set _pending_update so LSP refreshes on next render#2491ScottCUSA wants to merge 1 commit into
ScottCUSA wants to merge 1 commit into
Conversation
Setters flag _pending_update so LSP refreshes on next render after runtime provider changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2476
Description
The InputState.lsp providers fields are public, but setting them does not refresh the Lsp state until the next time the InputState's text is changed. This adds setter methods to the InputState. Each setter assigns it's provider, then set's the _pending_update flag so that the Lsp state is refreshed on the next render.
Break Changes
No Breaking Changes. Added public InputState methods.
How to Test
Create an InputState. Add use the setters to update the hover provider, color provider, etc. and watch the Input refresh as expected.
ex:
editing text
Checklist
cargo runfor story tests related to the changes.