Conversation
alrevuelta
left a comment
There was a problem hiding this comment.
Thanks, first two changes lgtm.
But not sure I see value in adding some of the other changes. inject_traffic.sh and run_compose.sh are just wrappers. More scripts, more code, more possible things to fail and missconfigure. Kind of goes against the principle of keep it simple. The less moving parts the better. Note that this applies to waku-simulator repo, but if you find this useful for testing, it seems like a great tool. But unsure if we should add it to the repo. Let me know if I'm missing something.
The two scripts have proven quite useful to me, it allows me to run simulations more quickly when Ineed to change parameters. I figured that since they're useful to me it might prove useful to somebody else, hence posting them here. If you think they make the repo more complex I can just pull them away, of course. Last one, the commented out |
:Zflag to fix volume sharing on some OSs/devvolume sharing to fix disk sharing on some OSsinject_traffic.shscript, which allows to easily change the traffic injection parameters.run_compose.shscript, which allows to easily change the simulation parameters.