Repository navigation
fix: report zero volume from useTrackVolume - #473
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
changt,
davidliu,
hiroshihorie and
xianshijing-lk
as code owners
October 10, 2026 19:58
🦋 Changeset detectedLatest commit: b3bc601 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
useTrackVolumeso it reports silence.The native volume processors emit
volume: 0when a track is silent or muted. The event handler checkedevent.volumefor truthiness, so a value of0was ignored and the hook kept returning the last non-zero volume. A level meter built on the hook stays stuck at its last level after the speaker stops.The handler now only skips events where
volumeisnullorundefined.Testing:
0fails before the change (Expected: 0,Received: 0.4) and passes after it. It needsreact-test-rendererand a jest environment change, so it is not included. It can be added on request.yarn lintandyarn typescriptpass.