Conversation
Signed-off-by: Mouad BANI <[email protected]>
Signed-off-by: Mouad BANI <[email protected]>
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| function tinybirdWhereClause(channelUrl: string, segmentId: string, types: string[]): string { | ||
| const ch = channelUrl.replace(/'/g, "\\'") |
|
|
||
| function tinybirdWhereClause(channelUrl: string, segmentId: string, types: string[]): string { | ||
| const ch = channelUrl.replace(/'/g, "\\'") | ||
| const seg = segmentId.replace(/'/g, "\\'") |
| segmentId: string, | ||
| type: string, | ||
| ): Promise<Set<string>> { | ||
| const ch = channelUrl.replace(/'/g, "\\'") |
| type: string, | ||
| ): Promise<Set<string>> { | ||
| const ch = channelUrl.replace(/'/g, "\\'") | ||
| const seg = segmentId.replace(/'/g, "\\'") |
There was a problem hiding this comment.
Pull request overview
Adds a one-off validation script to compare Gerrit activity counts between Gerrit’s REST API and Tinybird (with optional patchset validation) and emits a JSON report for debugging completeness issues.
Changes:
- Introduces
validate-gerrit-counts.tsto fetch Gerrit changes/patchsets, compare against Tinybird counts, and optionally compute set diffs. - Adds
pg-promiseto@crowd/nango-workerdevDependencies to support the new script. - Updates lockfile accordingly.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/apps/nango_worker/src/bin/validate-gerrit-counts.ts | New validator CLI/script that queries Gerrit + Tinybird and writes a diff report. |
| services/apps/nango_worker/package.json | Adds pg-promise (devDependency) to support the new script. |
| pnpm-lock.yaml | Lockfile updates for pg-promise and dependency graph normalization. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "devDependencies": { | ||
| "@types/node": "^20.8.2", | ||
| "nodemon": "^3.0.1" | ||
| "nodemon": "^3.0.1", | ||
| "pg-promise": "^11.4.3" |
There was a problem hiding this comment.
pg-promise is added as a devDependency only to support this script's direct connection usage. If you switch this script to use the existing shared DB helpers (via @crowd/data-access-layer/@crowd/database), this dependency can likely be removed; otherwise consider whether it should be a runtime dependency instead of devDependency.
No description provided.