test(protocols): stabilize wlr screencopy fixture - #1369
Draft
zorowk wants to merge 2 commits into
Draft
Conversation
zorowk
marked this pull request as draft
September 2, 2026 08:25
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zorowk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideStabilizes the wlroots screencopy fixture by replacing the implicit 1280×720 output with a single explicit 1920×1080 output, deriving rendered and capture dimensions from configure/capture events, and formatting the client and documentation for clearer diagnostics and maintenance. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
zorowk
force-pushed
the
fix_screencopy
branch
from
September 7, 2026 06:12
b7241e7 to
b2b87a8
Compare
added 2 commits
September 7, 2026 15:17
Protocol tests run an uninstalled Treeland build, while the screencopy fixture needs deterministic headless output dimensions. - Use the build-tree treeland-xwayland wrapper when running protocol tests. - Preserve the installed Xwayland-wrapper default unless WLR_XWAYLAND is explicitly configured. - Create the documented 1920x1080 screencopy fixture and derive client dimensions from configure events. Keep protocol fixtures runnable and deterministic in CI without depending on an installed wrapper.
wlr-screencopy protocol test - Capture output render state around the fixture render. - Report the state only when a capture frame fails. Make CI failures distinguish a missing output commit from a screencopy copy failure
zorowk
force-pushed
the
fix_screencopy
branch
from
September 7, 2026 07:18
b2b87a8 to
7da90ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screencopy protocol test relied on wlroots implicit 1280x720 output while its fixture documentation and client expected 1920x1080.
A deterministic single output keeps the captured frame dimensions aligned with the rendered source buffer.
Summary by Sourcery
Stabilize the wlroots screencopy protocol test with a deterministic 1920×1080 output and configuration-driven capture validation.
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores: