Skip to content

style(tests): remove consecutive blank lines in tests directory - #1324

Draft
deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/git-commit/2f85c09b
Draft

style(tests): remove consecutive blank lines in tests directory#1324
deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/git-commit/2f85c09b

Conversation

@deepin-wm

@deepin-wm deepin-wm commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

修复 tests 目录中遗留的两行空格问题

tests/ 目录下 36 个文件中的连续空行(两行及以上)合并为单行空行,共删除 160 行多余空行。纯空白行变更,不影响编译和运行时行为。

改动范围

  • tests/protocols/ 下的协议测试代码(.c/.h/.cpp
  • tests/test_effect_glass/main.cpp
  • tests/test_protocol_window-management/main.cpp
  • tests/protocols/framework/README.md

相关 Issue

WM-323

Summary by Sourcery

Enhancements:

  • Normalize formatting across the tests directory by removing consecutive blank lines.

Collapse multiple consecutive blank lines into single ones across
36 files in tests/ to fix leftover style issues.

将 tests/ 目录下 36 个文件中的连续空行合并为单行,修复遗留风格问题。

Log: 修复 tests 目录中遗留的连续空行问题
Influence: 纯空白行清理,不影响编译和运行时行为。
@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR normalizes whitespace in the tests directory by collapsing consecutive blank lines into single blank lines across protocol test sources, headers, and two test mains, ensuring consistent formatting without changing any logic or behavior.

File-Level Changes

Change Details Files
Normalize consecutive blank lines to single blank lines across protocol test sources and headers under tests/protocols/.
  • Remove extra blank lines between struct definitions, field groups, and function declarations
  • Remove redundant blank lines between test helper functions and protocol_test_run implementations
  • Tighten spacing in various treeland-* protocol C/C++ files and headers while preserving comments and code order
tests/protocols/framework/README.md
tests/protocols/treeland-app-id-resolver-v1/setup.cpp
tests/protocols/treeland-app-id-resolver-v1/treeland-app-id-resolver-v1.c
tests/protocols/treeland-app-id-resolver-v1/treeland-app-id-resolver-v1.h
tests/protocols/treeland-capture-unstable-v1/treeland-capture-unstable-v1.h
tests/protocols/treeland-dde-shell-v1/treeland-dde-shell-v1.h
tests/protocols/treeland-ddm-v1/treeland-ddm-v1.c
tests/protocols/treeland-ddm-v1/treeland-ddm-v1.h
tests/protocols/treeland-foreign-toplevel-manager-v1/treeland-foreign-toplevel-manager-v1.h
tests/protocols/treeland-keyboard-state-notify-unstable-v1/treeland-keyboard-state-notify-unstable-v1.c
tests/protocols/treeland-output-manager-v1/treeland-output-manager-v1.c
tests/protocols/treeland-output-manager-v1/treeland-output-manager-v1.h
tests/protocols/treeland-personalization-manager-v1/treeland-personalization-manager-v1.c
tests/protocols/treeland-personalization-manager-v1/treeland-personalization-manager-v1.h
tests/protocols/treeland-prelaunch-splash-v2/treeland-prelaunch-splash-v2.h
tests/protocols/treeland-screensaver-v1/setup.cpp
tests/protocols/treeland-screensaver-v1/treeland-screensaver-v1.c
tests/protocols/treeland-screensaver-v1/treeland-screensaver-v1.h
tests/protocols/treeland-shortcut-manager-v2/treeland-shortcut-manager-v2.h
tests/protocols/treeland-virtual-output-manager-v1/setup.cpp
tests/protocols/treeland-virtual-output-manager-v1/treeland-virtual-output-manager-v1.c
tests/protocols/treeland-virtual-output-manager-v1/treeland-virtual-output-manager-v1.h
tests/protocols/treeland-wallpaper-color-v1/setup.cpp
tests/protocols/treeland-wallpaper-color-v1/treeland-wallpaper-color-v1.h
tests/protocols/treeland-wallpaper-manager-unstable-v1/treeland-wallpaper-manager-unstable-v1.c
tests/protocols/treeland-wallpaper-manager-unstable-v1/treeland-wallpaper-manager-unstable-v1.h
tests/protocols/treeland-wallpaper-shell-unstable-v1/setup.cpp
tests/protocols/treeland-wallpaper-shell-unstable-v1/treeland-wallpaper-shell-unstable-v1.h
tests/protocols/treeland-window-management-v1/setup.cpp
tests/protocols/treeland-window-management-v1/treeland-window-management-v1.c
tests/protocols/treeland-window-management-v1/treeland-window-management-v1.h
tests/protocols/treeland-wine-window-management-unstable-v1/treeland-wine-window-management-unstable-v1.c
tests/protocols/treeland-wine-window-management-unstable-v1/treeland-wine-window-management-unstable-v1.h
tests/protocols/treeland-wine-window-state-unstable-v1/treeland-wine-window-state-unstable-v1.c
Normalize blank-line formatting in higher-level test mains and documentation.
  • Remove extra blank line after license header in test_protocol_window-management main
  • Remove redundant blank lines between Qt test slots in test_effect_glass
  • Remove stray blank line before a section heading in the protocol framework README
tests/test_effect_glass/main.cpp
tests/test_protocol_window-management/main.cpp
tests/protocols/framework/README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-bot

deepin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 0.9.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants