fix: add dev-tools package dependencies to DTK dev packages - #579
Merged
Conversation
1. Add libdtk6core-bin dependency to libdtk6core-dev package (DTK6) 2. Add libdtkcore5-bin dependency to libdtkcore-dev package (DTK5) 3. Ensure development packages pull in matching version tools packages 4. Maintain consistent version alignment between dev libraries and tools Log: Enhanced DTK development packages to include matching tools dependencies Influence: 1. Verify dev package installation includes corresponding tools packages 2. Confirm version alignment between dev and tools packages 3. Test installation with versioned dependencies in offline environments 4. Validate compatibility with existing build systems using DTK dev packages chore: 为 DTK 开发包添加配套工具包依赖 1. 为 libdtk6core-dev 包（DTK6）添加 libdtk6core-bin 依赖 2. 为 libdtkcore-dev 包（DTK5）添加 libdtkcore5-bin 依赖 3. 确保开发包安装时自动引入对应版本的工具包 4. 保持开发库与工具包之间版本一致性 Log: 增强 DTK 开发包，新增配套工具包依赖 Influence: 1. 验证开发包安装时是否包含对应的工具包 2. 确认开发包与工具包之间版本一致性 3. 在离线环境中测试带版本依赖的安装过程 4. 验证现有使用 DTK 开发包的构建系统兼容性
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate DTK development Debian packages so they depend on their corresponding tools (bin) packages, ensuring version alignment between dev libraries and tools for DTK5 and DTK6. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When adding the *-bin dependencies to the dev packages, ensure the dependency version is explicitly tied (e.g.
= ${binary:Version}) to avoid mismatches between library and tools in mixed-repo environments. - Double-check that introducing
libdtk6core-binandlibdtkcore5-binas hardDependsdoes not create circular or undesired upgrade chains; if the tools are optional at build time, considerRecommendsorSuggestsinstead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When adding the *-bin dependencies to the dev packages, ensure the dependency version is explicitly tied (e.g. `= ${binary:Version}`) to avoid mismatches between library and tools in mixed-repo environments.
- Double-check that introducing `libdtk6core-bin` and `libdtkcore5-bin` as hard `Depends` does not create circular or undesired upgrade chains; if the tools are optional at build time, consider `Recommends` or `Suggests` instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
deepin pr auto review★ 总体评分：75分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/debian/control b/debian/control
index b987b7c4..12345678 100644
--- a/debian/control
+++ b/debian/control
@@ -46,6 +46,7 @@ Description: Development ToolKit Core Utilities (DTK6 with Qt6)
Package: libdtk6core-dev
Architecture: any
Depends: libdtk6core (= ${binary:Version}),
+ libdtk6core-bin (= ${binary:Version}),
libdtkcommon-dev (>= 5.6.16), libdtk6log-dev
Build-Profiles: <!nodtk6>
Description: Development ToolKit Core Devel Library (DTK6 with Qt6)
@@ -84,6 +85,7 @@ Description: Development ToolKit Core Utilities (DTK5 with Qt5)
Package: libdtkcore-dev
Architecture: any
Depends: libdtkcore5 (= ${binary:Version}),
+ libdtkcore5-bin (= ${binary:Version}),
libdtkcommon-dev (>= 5.6.16), libdtklog-dev
Build-Profiles: <!nodtk5>
Description: Development ToolKit Core Devel Library (DTK5 with Qt5) |
BLumia
approved these changes
Aug 17, 2026
mhduiy
approved these changes
Aug 17, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Enhanced DTK development packages to include matching tools
dependencies
Influence:
packages
chore: 为 DTK 开发包添加配套工具包依赖
Log: 增强 DTK 开发包，新增配套工具包依赖
Influence:
Summary by Sourcery
Enhancements: