Skip to content

fix: electron app launch with wayland protocol by default - #19

Merged
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Groveer:master
Aug 27, 2026
Merged

fix: electron app launch with wayland protocol by default#19
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Groveer:master

Conversation

@Groveer

@Groveer Groveer commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Bug: https://pms.uniontech.com/bug-view-371259.html

Summary by Sourcery

Enable Wayland-by-default launching for supported Electron applications.

Bug Fixes:

  • Configure affected Electron applications to launch using the Wayland protocol by default.

Chores:

  • Add distribution configuration overrides for supported Electron applications, including Quark Cloud Drive, Baidu Netdisk, Feishu, DeepSeek, Doubao, Youdao Note, Tencent Docs, Microsoft Edge, Qwen, and Yuanbao.
  • Update the Debian changelog.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 2026.08.27
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai

sourcery-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes Electron application startup on Wayland by installing per-application Application Manager overrides that select the Wayland protocol by default for eleven affected applications, and documents the change in the Debian changelog.

File-Level Changes

Change Details Files
Add per-application Wayland launch overrides for Electron-based applications.
  • Create 90-override.json configuration under each application’s Wayland override directory.
  • Configure Electron applications to launch using the Wayland protocol by default.
  • Cover cloud drives, productivity apps, browsers, messaging/AI apps, and related desktop applications.
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/cn.quark.quark-cloud-drive/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.baidu.baidunetdisk/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.bytedance.feishu/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.deepseek.uos/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.doubao.uos/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.netease.youdaonote/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.qq.docs.tdappdesktop/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/microsoft-edge/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/qwen-work-cn/wayland/90-override.json
files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/yuanbao/wayland/90-override.json
Record the fix in the Debian package changelog.
  • Add a changelog entry describing the Electron/Wayland launch fix.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 98 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交为 Electron 应用添加 Wayland 协议默认启动配置覆盖,修复腾讯元宝、千问等应用首次无法启动的问题。JSON 配置文件语法正确、结构清晰,Exec 值使用标准 Electron Wayland 参数,无安全风险。仅存在少量文件尾部换行符不一致的轻微问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过(语法正确,逻辑清晰)

潜在问题:
✅ 未发现明显问题

建议:


2. 代码质量 ✅

评价: 优秀 ✅ 通过(代码结构清晰,注释完整)

潜在问题:

  1. files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.bytedance.feishu/wayland/90-override.json:10 - 文件末尾缺少换行符,与其他8个同类配置文件不一致(其余文件均以空行结尾)
  2. files/configs/overrides/org.deepin.dde.application-manager/org.deepin.dde.am.appoverride/com.doubao.uos/wayland/90-override.json:10 - 文件末尾缺少换行符,与其他8个同类配置文件不一致(其余文件均以空行结尾)

建议: 统一所有 JSON 配置文件的尾部换行符,建议所有文件均以换行符结尾(POSIX 标准)


3. 代码性能 ✅

评价: 优秀 ✅ 通过(性能良好,资源使用合理)

潜在问题:
✅ 未发现明显问题

建议:


4. 代码安全 🔒

存在0个安全漏洞

评价: 优秀 ✅ 通过(安全合规)

🔐 发现 0 个安全漏洞

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个

安全漏洞详情:
✅ 未发现安全漏洞

安全分析:

  • Exec 值 !AM_FULL! --enable-features=UseOzonePlatform --ozone-platform=wayland --enable-wayland-ime 中,!AM_FULL! 为应用管理器宏占位符,非用户输入,无命令注入风险
  • --enable-features=UseOzonePlatform--ozone-platform=wayland--enable-wayland-ime 为标准 Electron/Chromium Wayland 启动参数,无安全风险
  • permissions: "readwrite" 符合覆盖配置的预期用途
  • 无硬编码密钥、无敏感信息泄露

建议:


📝 代码目的与审查结论

代码目的: 修复 Bug 371259(腾讯元宝、千问等 Electron 应用程序首次无法打开启动运行),通过为 10 个 Electron 应用添加 Wayland 协议默认启动配置覆盖。

修改文件清单(11个文件,新增 114 行):

  1. debian/changelog - 新增版本条目 deepin-osconfig (2026.08.27)
  2. 10 个 JSON 配置覆盖文件(夸克网盘、百度网盘、飞书、DeepSeek、豆包、有道笔记、腾讯文档、Microsoft Edge、千问、元宝)

审查结论: 代码实现与 commit 目的完全一致。通过添加 dsg.config.override 格式的 JSON 配置文件,为各 Electron 应用设置 Wayland 协议启动参数,有效解决 Wayland 环境下 Electron 应用首次无法启动的问题。所有 JSON 文件结构正确,参数配置合理,无安全风险。


💡 改进建议

统一文件尾部换行符:

com.bytedance.feishu 和 com.doubao.uos 两个配置文件末尾缺少换行符,建议统一添加:

{
    "magic": "dsg.config.override",
    "version": "1.0",
    "contents": {
        "Exec": {
            "value": "!AM_FULL! --enable-features=UseOzonePlatform --ozone-platform=wayland --enable-wayland-ime",
            "permissions": "readwrite"
        }
    }
}

(文件末尾以换行符 \n 结尾,与其他 8 个配置文件保持一致)


本报告由 AI 代码审查工具自动生成

@Zeno-sole

Copy link
Copy Markdown
Contributor

/integrate

@github-actions

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#4519
PrNumber: 4519
PrBranch: auto-integration-33046848582

@Zeno-sole
Zeno-sole merged commit f5a3f33 into linuxdeepin:master Aug 27, 2026
9 checks passed
@deepin-bot

deepin-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 2026.08.27
  • Tag SHA: 7b34030dd2570a7ad7f92005f1c430421bd8f7bf
  • Commit SHA: f5a3f337eae2ac9049fb0595d4e5ee0fd6920dc7
  • Tag Message:
    Release deepin-osconfig 2026.08.27
    
    
  • Tagger:
    • Name: Groveer
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants