fix: prioritize wired icon when both networks connected - #616
Open
wjyrich wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates network icon selection so an aggregate Connected state, representing simultaneously usable wired and wireless networks, displays the wired icon while preserving existing handling for other connection states. Flow diagram for network icon selectionflowchart TD
A["updateNetworkIcon()"] --> B{"networkStatus()"}
B -->|Connected| C["type = Wired"]
B -->|Other states| D["Preserve existing connection type"]
C --> E{"type"}
D --> E
E -->|Wireless| F["Display wireless icon"]
E -->|Wired| G["Display wired icon"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
caixr23
requested changes
Sep 9, 2026
1. Implemented primaryConnectionType() getter to return tracked connection type 2. Initialized m_primaryConnectionType to Wired in constructor 3. Enabled updatePrimaryConnectionType() method with signal emission 4. Added m_primaryConnectionType member in private data class Log: 新增主连接类型跟踪功能 Influence: 1. Test primaryConnectionType() returns default Wired at initialization 2. Verify updatePrimaryConnectionType() correctly updates when connection changes 3. Test primaryConnectionTypeChanged signal is emitted with new connection type 4. Test different connection types (Wired, Wireless, etc.) in various network scenarios 5. Verify no regression in airplane mode functionality feat: 启用主连接类型跟踪功能 1. 实现 primaryConnectionType() 查询当前跟踪的连接类型 2. 在构造函数中将 m_primaryConnectionType 初始化为有线连接 3. 启用 updatePrimaryConnectionType() 方法并支持信号发射 4. 在私有数据类中添加 m_primaryConnectionType 成员变量 Log: 新增主连接类型跟踪功能 Influence: 1. 测试 primaryConnectionType() 在初始化时返回默认的有线类型 2. 验证 updatePrimaryConnectionType() 在连接状态变化时正确更新 3. 测试 primaryConnectionTypeChanged 信号在连接类型变化时正确发射 4. 在各种网络场景下测试不同连接类型(有线、无线等)的区分 5. 验证飞行模式功能无回归问题 PMS: BUG-375223
wjyrich
force-pushed
the
fix-bug-375223
branch
from
September 9, 2026 05:46
fcb113a to
9cf952d
Compare
Contributor
|
TAG Bot New tag: 2.0.100 |
Contributor
|
TAG Bot New tag: 2.0.101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Taskbar network icon now prioritizes wired connection display when multiple networks are active
Influence:
fix: 有线和无线同时连接时优先显示有线图标
Log: 当多网络同时连接时,任务栏网络图标优先显示有线连接
Influence:
PMS: BUG-375223
Summary by Sourcery
Prioritize wired connectivity by making the network manager’s primary connection type stateful and observable.
Bug Fixes:
Enhancements: