Skip to content

fix: Add icon resources - #414

Merged
caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master
Oct 17, 2025
Merged

caixr23 merged 1 commit into
linuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23

@caixr23 caixr23 commented Oct 17, 2025 •

Copy link
Copy Markdown
Contributor

Add icon resources

pms: TASK-381263

Summary by Sourcery

Add network icon SVG resources to the NetworkSecretDialog, integrate them into the build, and adjust window flags to use Qt::Tool for consistent behavior.

New Features:

  • Add qrc resource file containing network icon SVGs (VPN, wired, wireless).

Enhancements:

  • Update CMakeLists to include the new .qrc file in the build.
  • Change NetworkSecretDialog window flags to use Qt::Tool instead of Qt::Dialog on both Wayland and other sessions.

Add icon resources

pms: TASK-381263
@sourcery-ai

sourcery-ai Bot commented Oct 17, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR integrates new SVG icon assets into the network secret dialog by creating a Qt resource file and updating the build configuration, and also standardizes the dialog window type by switching from Qt::Dialog to Qt::Tool on all sessions.

Class diagram for NetworkSecretDialog window flag changes

classDiagram
class NetworkSecretDialog {
  +initUI()
  -setWindowFlags(Qt::WindowStaysOnTopHint | Qt::Dialog) [removed]
  -setWindowFlags(Qt::WindowStaysOnTopHint | Qt::FramelessWindowHint | Qt::Dialog) [removed]
  +setWindowFlags(Qt::WindowStaysOnTopHint | Qt::Tool) [added]
  +setWindowFlags(Qt::WindowStaysOnTopHint | Qt::FramelessWindowHint | Qt::Tool) [added]
}
Loading

File-Level Changes

Change Details Files
Switch dialog window flags to use Qt::Tool
  • Replaced Qt::Dialog with Qt::Tool for Wayland sessions
  • Replaced Qt::Dialog with Qt::Tool for non-Wayland sessions
network-service-plugin/dde-network-secret-dialog/networksecretdialog.cpp
Add Qt resource file and icon assets to build
  • Added qrc/dde-network-secret-dialog.qrc to the executable's source list
  • Created a QRC file listing new SVG icons
  • Added three SVG icon files under qrc/icons
network-service-plugin/dde-network-secret-dialog/CMakeLists.txt
network-service-plugin/dde-network-secret-dialog/qrc/dde-network-secret-dialog.qrc
network-service-plugin/dde-network-secret-dialog/qrc/icons/network-vpn_64px.svg
network-service-plugin/dde-network-secret-dialog/qrc/icons/network-wired_64px.svg
network-service-plugin/dde-network-secret-dialog/qrc/icons/notification-network-wireless-full_48px.svg

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@caixr23
caixr23 merged commit 232e4e0 into linuxdeepin:master Oct 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants