Repository navigation
fix: Add icon resources - #414
Merged
Merged
Conversation
Add icon resources pms: TASK-381263
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR integrates new SVG icon assets into the network secret dialog by creating a Qt resource file and updating the build configuration, and also standardizes the dialog window type by switching from Qt::Dialog to Qt::Tool on all sessions. Class diagram for NetworkSecretDialog window flag changesclassDiagram
class NetworkSecretDialog {
+initUI()
-setWindowFlags(Qt::WindowStaysOnTopHint | Qt::Dialog) [removed]
-setWindowFlags(Qt::WindowStaysOnTopHint | Qt::FramelessWindowHint | Qt::Dialog) [removed]
+setWindowFlags(Qt::WindowStaysOnTopHint | Qt::Tool) [added]
+setWindowFlags(Qt::WindowStaysOnTopHint | Qt::FramelessWindowHint | Qt::Tool) [added]
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add icon resources
pms: TASK-381263
Summary by Sourcery
Add network icon SVG resources to the NetworkSecretDialog, integrate them into the build, and adjust window flags to use Qt::Tool for consistent behavior.
New Features:
Enhancements: