Skip to content

fix: add comprehensive wireless network icons - #409

Merged
robertkill merged 1 commit into
linuxdeepin:masterfrom
robertkill:master
Oct 16, 2025
Merged

robertkill merged 1 commit into
linuxdeepin:masterfrom
robertkill:master

Conversation

@robertkill

@robertkill robertkill commented Oct 16, 2025 •

Copy link
Copy Markdown
Contributor

Added multiple wireless network icon variants to support different network states and security levels:

  1. Added Wi-Fi 6 and Wi-Fi 7 specific icons with various signal strengths (none, low, medium, high, full)
  2. Added secure and non-secure variants for different network states
  3. Included offline, no-route, and warning state icons
  4. Added symbolic links for disconnect and offline states
  5. Updated network.qrc resource file to include all new icons

Log: Added comprehensive wireless network icons for better network status visualization

Influence:

  1. Test network status display with different Wi-Fi generations (6 and 7)
  2. Verify icon display for various signal strength levels
  3. Check secure vs non-secure network icon differentiation
  4. Test offline and no-route network state icons
  5. Verify symbolic links work correctly for disconnect states
  6. Ensure all icons load properly in the network interface

feat: 添加全面的无线网络图标

添加了多种无线网络图标变体以支持不同的网络状态和安全级别:

  1. 添加了 Wi-Fi 6 和 Wi-Fi 7 特定图标,包含各种信号强度(无、弱、中、 强、满格)
  2. 为不同网络状态添加了安全和非安全变体
  3. 包含了离线、无路由和警告状态图标
  4. 添加了断开连接和离线状态的符号链接
  5. 更新了 network.qrc 资源文件以包含所有新图标

Log: 新增全面的无线网络图标,提升网络状态可视化效果

Influence:

  1. 测试不同 Wi-Fi 代际(6 和 7)的网络状态显示
  2. 验证各种信号强度级别的图标显示
  3. 检查安全与非安全网络图标的区分
  4. 测试离线和无路由网络状态图标
  5. 验证断开连接状态的符号链接是否正常工作
  6. 确保所有图标在网络界面中正确加载

PMS: BUG-337027

Summary by Sourcery

Add a comprehensive set of wireless network icons to support multiple Wi-Fi generations, signal strengths, security states, and offline conditions.

New Features:

  • Add Wi-Fi 6 and Wi-Fi 7 icons for signal strengths none, low, medium, high, and full
  • Introduce secure and non-secure variants for each network state
  • Include offline, no-route, warning, and disconnect state icons with symbolic links

Enhancements:

  • Update network.qrc resource file to include all new icons

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider grouping and ordering the new icon entries in network.qrc alphabetically or by network state to improve maintainability as more icons get added.
  • Verify that all newly added SVG icons are optimized (e.g., minified) so the expanded resource bundle doesn’t adversely affect application startup or memory footprint.
  • Ensure the symbolic link entries for disconnect and offline states correctly reference their targets and won’t break if filenames change later.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider grouping and ordering the new icon entries in network.qrc alphabetically or by network state to improve maintainability as more icons get added.
- Verify that all newly added SVG icons are optimized (e.g., minified) so the expanded resource bundle doesn’t adversely affect application startup or memory footprint.
- Ensure the symbolic link entries for disconnect and offline states correctly reference their targets and won’t break if filenames change later.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai

sourcery-ai Bot commented Oct 16, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces a complete set of Wi-Fi 6 and 7 icons covering all signal strengths, security states, and special network statuses, updates the QRC resource, and adds symbolic links for disconnect/offline visuals.

File-Level Changes

Change Details Files
Add Wi-Fi 6 & 7 icons for all signal levels
  • Introduce Wi-Fi 6 icons for none/low/medium/high/full signals
  • Introduce Wi-Fi 7 icons for none/low/medium/high/full signals
net-view/window/qrc/built-in-icons/network-wireless-wifi6-signal-*.dci
net-view/window/qrc/built-in-icons/network-wireless-wifi7-signal-*.dci
Add secure and non-secure variants
  • Implement locked (secure) icons for each state
  • Implement unlocked (non-secure) icons for each state
net-view/window/qrc/built-in-icons/network-wireless-*-secure-*.dci
net-view/window/qrc/built-in-icons/network-wireless-*-unsecure-*.dci
Include offline, no-route, and warning state icons
  • Add offline icons (full and symbolic)
  • Add no-route icon
  • Add warning icon
net-view/window/qrc/built-in-icons/network-wireless-offline-*.dci
net-view/window/qrc/built-in-icons/network-wireless-no-route.dci
net-view/window/qrc/built-in-icons/network-wireless-warning.dci
Add symbolic links for disconnect/offline states
  • Create symbolic link for disconnect state
  • Create symbolic link for offline full-signal state
net-view/window/qrc/built-in-icons/network-wireless-disconnect.dci
net-view/window/qrc/built-in-icons/network-wireless-offline-signal-full-symbolic.dci
Update QRC resource file
  • Include all new icon files and symbolic links in network.qrc
net-view/window/qrc/network.qrc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Added multiple wireless network icon variants to support different
network states and security levels:
1. Added Wi-Fi 6 and Wi-Fi 7 specific icons with various signal
strengths (none, low, medium, high, full)
2. Added secure and non-secure variants for different network states
3. Included offline, no-route, and warning state icons
4. Added symbolic links for disconnect and offline states
5. Updated network.qrc resource file to include all new icons

Log: Added comprehensive wireless network icons for better network
status visualization

Influence:
1. Test network status display with different Wi-Fi generations (6 and
7)
2. Verify icon display for various signal strength levels
3. Check secure vs non-secure network icon differentiation
4. Test offline and no-route network state icons
5. Verify symbolic links work correctly for disconnect states
6. Ensure all icons load properly in the network interface

feat: 添加全面的无线网络图标

添加了多种无线网络图标变体以支持不同的网络状态和安全级别:
1. 添加了 Wi-Fi 6 和 Wi-Fi 7 特定图标,包含各种信号强度(无、弱、中、
强、满格)
2. 为不同网络状态添加了安全和非安全变体
3. 包含了离线、无路由和警告状态图标
4. 添加了断开连接和离线状态的符号链接
5. 更新了 network.qrc 资源文件以包含所有新图标

Log: 新增全面的无线网络图标,提升网络状态可视化效果

Influence:
1. 测试不同 Wi-Fi 代际(6 和 7)的网络状态显示
2. 验证各种信号强度级别的图标显示
3. 检查安全与非安全网络图标的区分
4. 测试离线和无路由网络状态图标
5. 验证断开连接状态的符号链接是否正常工作
6. 确保所有图标在网络界面中正确加载

PMS: BUG-337027
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

根据提供的git diff,我看到这是一系列关于网络图标的文件重命名和更新操作。以下是我的审查意见:

  1. 文件命名规范:
  • 修正了多个文件名中的拼写错误,如将"wirelss"改为"wireless",这是很好的改进
  • 建议在未来的文件命名中保持一致的命名规范,避免出现类似的拼写错误
  1. 文件变更:
  • 添加了新的图标文件,如network-wireless-7-*系列图标,表明可能是在更新网络图标的表示
  • 新增了两个符号链接文件:
    • network-wireless-disconnect.dci -> network-wireless-signal-none-symbolic.dci
    • network-wireless-offline-signal-full.dci -> network-wireless-offline-symbolic.dci
      符号链接的使用是合理的,可以减少重复资源
  1. 资源文件管理:
  • network.qrc文件中添加了大量新的图标资源
  • 建议考虑将图标资源按功能或版本进行分组,以提高资源文件的可维护性
  1. 改进建议:
  • 考虑添加版本控制注释,说明图标更新的原因和目的
  • 建议为新增的图标创建一个命名约定文档,确保未来添加新图标时保持一致性
  • 对于符号链接的使用,建议添加注释说明其用途,便于其他开发者理解
  1. 安全性考虑:
  • 文件权限设置(mode 120000)正确,确保了符号链接的安全性
  • 建议定期检查符号链接的有效性,防止出现断链

总体来说,这次变更主要是为了统一命名规范和更新图标资源,方向是正确的。建议在后续开发中继续保持良好的命名规范,并适当添加文档说明变更原因。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robertkill
robertkill merged commit 090090e into linuxdeepin:master Oct 16, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants